refactor: convert counter_status enum to enum class
#5880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- converted enum counter_status to enum class - added clang's `.cache` dir to gitignore - formatted server/papi.cpp
bhumitattarde
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
|
Can one of the admins verify this patch? |
|
@bhumitattarde thanks for this. Unfortunately, this seems to be a duplicate of #5857. |
|
@hkaiser Aah, I did not see that. My apologies. I'll close this PR. |
No reason to apologize. We really appreciate your initiative. Let's talk about things before you start working on something to avoid these situations. |
Thank you. I'll definitely keep that in mind next time. : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4702
Proposed Changes
counter_statusenum to enum class..cache& cmake-tools'scmake-builddirectory to.gitignore. These are some of the most widely used extensions for C++ development using VSCode.server/papi.cpp(since this file was getting touched as a part of this change).Any background context you want to provide?
This change can probably be improved by making
ostreamoverload print enum name strings instead of enum int values. Thoughts?Checklist
Not all points below apply to all pull requests.