Futures attempt to execute threads directly if those have not started executing #6099

hkaiser · 2022-12-07T23:58:24Z

adding new API function hpx::threads::get_outer_self_id

StellarBot · 2022-12-08T14:19:14Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	(=)	(=)

Info

Property	Before	After
HPX Commit	`d5655f8`	`12ad8af`
HPX Datetime	2022-05-31T12:57:29+00:00	2022-12-08T14:00:01+00:00
Datetime	2022-05-31T15:13:01.357969+02:00	2022-12-08T15:17:48.968956+01:00
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Clustername	daint	daint
Envfile
Hostname	nid01193	nid01598

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	-

Info

Property	Before	After
HPX Commit	`d5655f8`	`12ad8af`
HPX Datetime	2022-05-31T12:57:29+00:00	2022-12-08T14:00:01+00:00
Datetime	2022-05-31T15:13:18.026239+02:00	2022-12-08T15:18:06.081889+01:00
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Clustername	daint	daint
Envfile
Hostname	nid01193	nid01598

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	(=)	(=)
Stream Benchmark - Scale	(=)	(=)	(=)
Stream Benchmark - Triad	(=)	(=)	(=)
Stream Benchmark - Copy	(=)	(=)	(=)

Info

Property	Before	After
HPX Commit	`71d8dbe`	`12ad8af`
HPX Datetime	2021-11-10T19:14:21+00:00	2022-12-08T14:00:01+00:00
Datetime	2021-11-10T20:28:18.266961+01:00	2022-12-08T15:18:21.342210+01:00
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Clustername	daint	daint
Envfile
Hostname	nid00120	nid01598

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

StellarBot · 2022-12-08T17:49:16Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	(=)	(=)

Info

Property	Before	After
HPX Datetime	2022-05-31T12:57:29+00:00	2022-12-08T17:30:39+00:00
HPX Commit	`d5655f8`	`138dae8`
Datetime	2022-05-31T15:13:01.357969+02:00	2022-12-08T18:48:17.538240+01:00
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Clustername	daint	daint
Hostname	nid01193	nid00097
Envfile

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	+

Info

Property	Before	After
HPX Datetime	2022-05-31T12:57:29+00:00	2022-12-08T17:30:39+00:00
HPX Commit	`d5655f8`	`138dae8`
Datetime	2022-05-31T15:13:18.026239+02:00	2022-12-08T18:48:33.891186+01:00
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Clustername	daint	daint
Hostname	nid01193	nid00097
Envfile

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	(=)	(=)
Stream Benchmark - Scale	(=)	(=)	(=)
Stream Benchmark - Triad	-	(=)	(=)
Stream Benchmark - Copy	(=)	(=)	(=)

Info

Property	Before	After
HPX Datetime	2021-11-10T19:14:21+00:00	2022-12-08T17:30:39+00:00
HPX Commit	`71d8dbe`	`138dae8`
Datetime	2021-11-10T20:28:18.266961+01:00	2022-12-08T18:48:49.290784+01:00
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Clustername	daint	daint
Hostname	nid00120	nid00097
Envfile

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

StellarBot · 2022-12-11T00:07:37Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	(=)	(=)

Info

Property	Before	After
HPX Commit	`d5655f8`	`64783ac`
HPX Datetime	2022-05-31T12:57:29+00:00	2022-12-10T23:51:35+00:00
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Hostname	nid01193	nid01030
Datetime	2022-05-31T15:13:01.357969+02:00	2022-12-11T01:06:43.939432+01:00
Clustername	daint	daint
Envfile

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	+

Info

Property	Before	After
HPX Commit	`d5655f8`	`64783ac`
HPX Datetime	2022-05-31T12:57:29+00:00	2022-12-10T23:51:35+00:00
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Hostname	nid01193	nid01030
Datetime	2022-05-31T15:13:18.026239+02:00	2022-12-11T01:06:59.960993+01:00
Clustername	daint	daint
Envfile

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	-	(=)
Stream Benchmark - Scale	(=)	=	=
Stream Benchmark - Triad	(=)	(=)	(=)
Stream Benchmark - Copy	(=)	(=)	(=)

Info

Property	Before	After
HPX Commit	`71d8dbe`	`64783ac`
HPX Datetime	2021-11-10T19:14:21+00:00	2022-12-10T23:51:35+00:00
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Hostname	nid00120	nid01030
Datetime	2021-11-10T20:28:18.266961+01:00	2022-12-11T01:07:15.316774+01:00
Clustername	daint	daint
Envfile

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

StellarBot · 2022-12-11T00:18:02Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	(=)	(=)

Info

Property	Before	After
HPX Datetime	2022-05-31T12:57:29+00:00	2022-12-11T00:04:52+00:00
HPX Commit	`d5655f8`	`1cb023b`
Hostname	nid01193	nid00111
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Datetime	2022-05-31T15:13:01.357969+02:00	2022-12-11T01:16:40.730928+01:00
Clustername	daint	daint

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	=

Info

Property	Before	After
HPX Datetime	2022-05-31T12:57:29+00:00	2022-12-11T00:04:52+00:00
HPX Commit	`d5655f8`	`1cb023b`
Hostname	nid01193	nid00111
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Datetime	2022-05-31T15:13:18.026239+02:00	2022-12-11T01:16:57.415126+01:00
Clustername	daint	daint

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	-	(=)
Stream Benchmark - Scale	(=)	(=)	(=)
Stream Benchmark - Triad	(=)	(=)	(=)
Stream Benchmark - Copy	(=)	(=)	(=)

Info

Property	Before	After
HPX Datetime	2021-11-10T19:14:21+00:00	2022-12-11T00:04:52+00:00
HPX Commit	`71d8dbe`	`1cb023b`
Hostname	nid00120	nid00111
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Datetime	2021-11-10T20:28:18.266961+01:00	2022-12-11T01:17:12.937465+01:00
Clustername	daint	daint

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

StellarBot · 2022-12-11T18:08:50Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	(=)	(=)

Info

Property	Before	After
HPX Datetime	2022-05-31T12:57:29+00:00	2022-12-11T17:51:39+00:00
HPX Commit	`d5655f8`	`954baaf`
Clustername	daint	daint
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Datetime	2022-05-31T15:13:01.357969+02:00	2022-12-11T19:07:45.281830+01:00
Envfile
Hostname	nid01193	nid00016

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	=

Info

Property	Before	After
HPX Datetime	2022-05-31T12:57:29+00:00	2022-12-11T17:51:39+00:00
HPX Commit	`d5655f8`	`954baaf`
Clustername	daint	daint
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Datetime	2022-05-31T15:13:18.026239+02:00	2022-12-11T19:08:01.937971+01:00
Envfile
Hostname	nid01193	nid00016

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	(=)	(=)
Stream Benchmark - Scale	(=)	(=)	(=)
Stream Benchmark - Triad	(=)	(=)	-
Stream Benchmark - Copy	(=)	(=)	(=)

Info

Property	Before	After
HPX Datetime	2021-11-10T19:14:21+00:00	2022-12-11T17:51:39+00:00
HPX Commit	`71d8dbe`	`954baaf`
Clustername	daint	daint
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Datetime	2021-11-10T20:28:18.266961+01:00	2022-12-11T19:08:17.388211+01:00
Envfile
Hostname	nid00120	nid00016

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

- flyby: additional unrelated cleanup

Pansysk75 · 2023-07-28T17:00:50Z

Although disabling run_as_child decreases allocations by a lot, here is still a leak-like issue arising with hpx:ini=hpx.stacks.use_guard_pages=0. I'm investigating it rn.

Here's some plots running suspend_thread_external test, where the effect of setting the hint to none is very visible (not so much in the total memory footprint, but in the # of allocations). Also notice the accumulating nature of the # of mappings when using no guard pages, which I cannot explain:

hkaiser · 2023-07-28T18:45:22Z

That would explain why the suspend_runtime et.al. now fail even for builders that don't enable the run_as_child hint by default.

Pansysk75 · 2023-07-28T18:49:49Z

That would explain why the suspend_runtime et.al. now fail even for builders that don't enable the run_as_child hint by default.

Here, does mmap-ing memory of (size + EXEC_PAGESIZE) make sense even if we are not using guard pages?

hpx/libs/core/coroutines/include/hpx/coroutines/detail/posix_utility.hpp

Lines 84 to 96 in dd17010

    
               inline void* alloc_stack(std::size_t size) 
        
               { 
        
                   void* real_stack = 
        
                       ::mmap(nullptr, size + EXEC_PAGESIZE, PROT_READ | PROT_WRITE, 
        
           #if defined(__APPLE__) 
        
                           MAP_PRIVATE | MAP_ANON | MAP_NORESERVE, 
        
           #elif defined(__FreeBSD__) 
        
                           MAP_PRIVATE | MAP_ANON, 
        
           #else 
        
                           MAP_PRIVATE | MAP_ANONYMOUS | MAP_NORESERVE, 
        
           #endif 
        
                           -1, 0);

Deallocation seems to not take EXEC_PAGESIZE into account if we don't use guard pages:

hpx/libs/core/coroutines/include/hpx/coroutines/detail/posix_utility.hpp

Lines 156 to 172 in dd17010

    
               inline void free_stack(void* stack, std::size_t size) 
        
               { 
        
           #if defined(HPX_HAVE_THREAD_GUARD_PAGE) 
        
                   if (use_guard_pages) 
        
                   { 
        
                       void** real_stack = 
        
                           static_cast<void**>(stack) - (EXEC_PAGESIZE / sizeof(void*)); 
        
                       ::munmap(static_cast<void*>(real_stack), size + EXEC_PAGESIZE); 
        
                   } 
        
                   else 
        
                   { 
        
                       ::munmap(stack, size); 
        
                   } 
        
           #else 
        
                   ::munmap(stack, size); 
        
           #endif 
        
               }

I'm not familiar with mmap and such, but this made me raise an eyebrow

hkaiser · 2023-07-28T18:51:09Z

Excellent catch! Could you patch that, please?

Pansysk75 · 2023-07-28T18:52:37Z

Excellent catch! Could you patch that, please?

Thank you, I'll do that :)

hkaiser · 2023-07-28T19:11:58Z

I'm also preparing a change right now that starts deleting stack segments of recycled threads once more then a certain number of threads have been recycled. That should keep the amount of memory allocated down a bit as well.

StellarBot · 2023-07-28T19:59:11Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	??	(=)

Info

Property	Before	After
HPX Datetime	2023-05-10T12:07:53+00:00	2023-07-28T19:24:21+00:00
HPX Commit	`dcb5415`	`f3f8ff1`
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Datetime	2023-05-10T14:50:18.616050-05:00	2023-07-28T14:30:05.676471-05:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Envfile
Clustername	rostam	rostam

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	---

Info

Property	Before	After
HPX Datetime	2023-05-10T12:07:53+00:00	2023-07-28T19:24:21+00:00
HPX Commit	`dcb5415`	`f3f8ff1`
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Datetime	2023-05-10T14:52:35.047119-05:00	2023-07-28T14:58:06.050998-05:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Envfile
Clustername	rostam	rostam

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	(=)	(=)
Stream Benchmark - Scale	=	(=)	(=)
Stream Benchmark - Triad	(=)	=	(=)
Stream Benchmark - Copy	(=)	=	(=)

Info

Property	Before	After
HPX Datetime	2023-05-10T12:07:53+00:00	2023-07-28T19:24:21+00:00
HPX Commit	`dcb5415`	`f3f8ff1`
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Datetime	2023-05-10T14:52:52.237641-05:00	2023-07-28T14:58:23.094324-05:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Envfile
Clustername	rostam	rostam

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

StellarBot · 2023-07-28T23:59:24Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	??	(=)

Info

Property	Before	After
HPX Commit	`dcb5415`	`8e94a22`
HPX Datetime	2023-05-10T12:07:53+00:00	2023-07-28T23:20:37+00:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Datetime	2023-05-10T14:50:18.616050-05:00	2023-07-28T18:30:19.100757-05:00
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	---

Info

Property	Before	After
HPX Commit	`dcb5415`	`8e94a22`
HPX Datetime	2023-05-10T12:07:53+00:00	2023-07-28T23:20:37+00:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Datetime	2023-05-10T14:52:35.047119-05:00	2023-07-28T18:58:30.325592-05:00
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	=	(=)
Stream Benchmark - Scale	=	=	(=)
Stream Benchmark - Triad	(=)	(=)	(=)
Stream Benchmark - Copy	(=)	(=)	(=)

Info

Property	Before	After
HPX Commit	`dcb5415`	`8e94a22`
HPX Datetime	2023-05-10T12:07:53+00:00	2023-07-28T23:20:37+00:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Datetime	2023-05-10T14:52:52.237641-05:00	2023-07-28T18:58:47.228080-05:00
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

hkaiser · 2023-07-30T15:14:26Z

@Pansysk75 your fix did the trick! I will roll back my change that limits the numer of recycled stacks as it made the performance tests fail. Let's see if after that change things will be still green.

Pansysk75 · 2023-07-30T16:13:59Z

@Pansysk75 your fix did the trick! I will roll back my change that limits the numer of recycled stacks as it made the performance tests fail. Let's see if after that change things will be still green.

Yes, things are much better.

The memory mappings now barely go above a few hundred, as the OS is able to merge the mapped areas more efficiently. Even with guard_pages=on, they are in the hundreds now (more than an order of magnitude less than before).
That seems very significant, so keep an eye out for any macroscopic effects it may have.

The only memory "concern" is the slightly higher memory usage when using direct execution (because of the immediate thread spawining), but it's not that significant. So the thread stack allocation / recycling change is not as crucial.

hkaiser · 2023-07-31T13:55:59Z

@Pansysk75 I think this is finally good to be merged. What do you think?

Pansysk75 · 2023-07-31T15:14:10Z

@hkaiser There is a single timed-out test on daint (I had a look yesterday but didn't get anywhere), but other than that, nothing further to add.

hkaiser · 2023-07-31T15:49:59Z

@hkaiser There is a single timed-out test on daint (I had a look yesterday but didn't get anywhere), but other than that, nothing further to add.

I believe this is unrelated. Could be another case of the synchronization object going out of scope too early.

hkaiser · 2023-07-31T15:50:04Z

bors merge

bors · 2023-07-31T16:09:26Z

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

Bors

hkaiser added category: core type: enhancement category: scheduler labels Dec 7, 2022

hkaiser added this to the 1.9.0 milestone Dec 7, 2022

hkaiser requested review from aurianer, msimberg and biddisco as code owners December 7, 2022 23:58

hkaiser force-pushed the direct_scoped_execution branch 5 times, most recently from 26b44d8 to 146d101 Compare December 8, 2022 13:59

hkaiser force-pushed the direct_scoped_execution branch 3 times, most recently from f470ea5 to 207af34 Compare December 8, 2022 17:30

hkaiser force-pushed the direct_scoped_execution branch 3 times, most recently from bdd2fb9 to eda6a19 Compare December 10, 2022 16:58

hkaiser marked this pull request as draft December 10, 2022 17:00

hkaiser force-pushed the direct_scoped_execution branch 3 times, most recently from f9d3a9c to 9e3b499 Compare December 11, 2022 00:04

hkaiser force-pushed the direct_scoped_execution branch from 9e3b499 to bb43390 Compare December 11, 2022 17:51

hkaiser force-pushed the direct_scoped_execution branch 2 times, most recently from f41533a to 731e192 Compare December 12, 2022 15:35

hkaiser and others added 5 commits July 27, 2023 18:38

Fixing more possible race conditions

a401784

Fix race condition

fa26c47

Fixing assert in schedule_pool test

d251bf6

- flyby: additional unrelated cleanup

Improve error handling

9d46648

Disable run_as_child mode for some of the tests

d3f50ae

hkaiser force-pushed the direct_scoped_execution branch from f6334d3 to d3f50ae Compare July 28, 2023 01:01

hkaiser force-pushed the direct_scoped_execution branch from 74c7216 to bdfd6d4 Compare July 28, 2023 19:24

hkaiser force-pushed the direct_scoped_execution branch 3 times, most recently from b73ca59 to 498c7c8 Compare July 30, 2023 20:41

Fix memory leak when not using guard pages

fe7a35d

hkaiser force-pushed the direct_scoped_execution branch from 498c7c8 to fe7a35d Compare July 30, 2023 21:01

hkaiser added this to the 1.10.0 milestone Jul 31, 2023

bors bot merged commit c16ae10 into master Jul 31, 2023
68 of 76 checks passed

bors bot deleted the direct_scoped_execution branch July 31, 2023 16:09

Futures attempt to execute threads directly if those have not started executing #6099

Futures attempt to execute threads directly if those have not started executing #6099

Conversation

hkaiser commented Dec 7, 2022

StellarBot commented Dec 8, 2022

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

StellarBot commented Dec 8, 2022

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

StellarBot commented Dec 11, 2022

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

StellarBot commented Dec 11, 2022

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

StellarBot commented Dec 11, 2022

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

Pansysk75 commented Jul 28, 2023 • edited Loading

hkaiser commented Jul 28, 2023

Pansysk75 commented Jul 28, 2023 • edited Loading

hkaiser commented Jul 28, 2023

Pansysk75 commented Jul 28, 2023

hkaiser commented Jul 28, 2023

StellarBot commented Jul 28, 2023

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

StellarBot commented Jul 28, 2023

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

hkaiser commented Jul 30, 2023

Pansysk75 commented Jul 30, 2023 • edited Loading

hkaiser commented Jul 31, 2023

Pansysk75 commented Jul 31, 2023

hkaiser commented Jul 31, 2023

hkaiser commented Jul 31, 2023

bors bot commented Jul 31, 2023

Pansysk75 commented Jul 28, 2023 •

edited

Loading

Pansysk75 commented Jul 28, 2023 •

edited

Loading

Pansysk75 commented Jul 30, 2023 •

edited

Loading