Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in get_executable_filename on FreeBSD #6499

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

yurivict
Copy link
Contributor

@yurivict yurivict commented May 31, 2024

The std::vector object needs to have the element allocated in order to take its address.

@yurivict yurivict requested a review from hkaiser as a code owner May 31, 2024 21:02
@jenkins-cscs
Copy link
Collaborator

Can one of the admins verify this patch?

@hkaiser
Copy link
Member

hkaiser commented May 31, 2024

The std::vector object needs to have the element allocated in order to take its address.

Excellent catch, thanks!

hkaiser
hkaiser previously approved these changes May 31, 2024
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

codacy-production bot commented Jun 1, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.15%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3521f71) 222028 188803 85.04%
Head commit (03d01dc) 191067 (-30961) 162766 (-26037) 85.19% (+0.15%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6499) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

The std::vector object needs to have the element allocated
in order to take its address.
@hkaiser hkaiser merged commit d08354d into STEllAR-GROUP:master Jun 9, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants