ensure joined routes are slash separated #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The active route may not have a slash at the end, yet if we call makeHref() or navigate() with a deeper segment, the route change fails.
|
Good idea, could you add a test for this? |
|
yes, i’ll try to add one in the morning.
…On Tue, Mar 13, 2018 at 7:05 PM Samuel Reed ***@***.***> wrote:
Good idea, could you add a test for this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#205 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjPrQoS6bJSvjEjzlRxwe8mOVf6sYWYks5teF7SgaJpZM4SpkNP>
.
|
|
Test added. :) |
|
Can this be published to npm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The active route may not have a slash at the end, yet if we call makeHref() or navigate() with a deeper segment, the route change fails.