This repository has been archived by the owner on Sep 22, 2024. It is now read-only.
New status and parentheses toggle #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just some small tweaks I made to this addon myself and thought others might like. Implementation might not be perfect. Allows you to toggle the parentheses placed around deck_count and adds a new status for when you're in the menu and have not cards left (Feeling good). I also made some changes to config.json and config.md to reflect these new features.
STadas
suggested changes
Apr 17, 2022
not to be confused with battle royale
|
I'm glad I could add to your code without causing any problems! Not sure why I left that tag in there, but I probably just wasn't thinking about it, lol. and honestly, I don't understand all the code right now, only the main parts and the snippets I wanted to change. I'll probably understand it better if/when I make more commits! |
STadas
approved these changes
Apr 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small changes I made myself that others might like. Adds a new status when in menu with no cards left and the option to toggle the parentheses around deck_count on or off. Implementation might not be perfect. Modified config.json and config.md to reflect changes.
I'm new to GitHub. Sorry if I messed something up somehow.
PS: My reasoning behind the first change is that I didn't like the addon displaying "slacking off" when I didn't have any cards left. Sure, I could add more, but maybe I just studied 500. At that point, I'm feeling good. I also just didn't like the deck_count parentheses (seems unnecessary to me) and would edit them out of main.py manually, but this would allow others to turn them off without any coding experience.