Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHY-14: Set EntityReferenceFieldProcessor #144

Merged
merged 2 commits into from
Jul 21, 2017
Merged

PHY-14: Set EntityReferenceFieldProcessor #144

merged 2 commits into from
Jul 21, 2017

Conversation

pookmish
Copy link
Contributor

@pookmish pookmish commented Jul 21, 2017 •
edited
Loading

READY FOR REVIEW

Summary

  • Fixed entity reference field breaking.

Needed By (Date)

  • today if possible

Urgency

  • high

Steps to Test

  1. Clone physics2
  2. run the capx importer to get the error
  3. checkout branch
  4. re-run importer
  5. no error should occur.

See Also

sherakama
sherakama approved these changes Jul 21, 2017
View reviewed changes
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible enough.

@sherakama sherakama merged commit f92f403 into php54-3.x Jul 21, 2017
@sherakama sherakama deleted the entityreference-fix branch July 21, 2017 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherakama sherakama sherakama approved these changes

Assignees

@sherakama sherakama

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pookmish @sherakama