Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-222: Set default encryption profile at install time #205

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

jbickar
Copy link
Contributor

@jbickar jbickar commented Feb 13, 2020

READY FOR REVIEW

Summary

  • Fixes borked installs on PHP 7.2+

Needed By (Date)

  • ASAP

Criticality

  • How critical is this PR on a 1-10 scale? 7/10
  • Affects all new installs

Steps to Test

  1. Check out 7.x-3.0-beta16
  2. Do a fresh install
  3. Try to submit the CAP credentials
  4. Weep at the fatal error before you
  5. Check out this branch
  6. Reinstall your site and reinstall this module
  7. Repeat Step 3
  8. Rejoice

Affected Projects or Products

  • CAPx
  • New D7 sites

Associated Issues and/or People

  • JIRA ticket: DEVOPS-222
  • Anyone who should be notified? (@pookmish )

See Also

@@ -431,7 +431,6 @@ function stanford_capx_update_7301() {

// Install the new encrypt settings.
stanford_capx_install_encrypt_settings();
variable_set('encrypt_default_config', STANFORD_CAPX_ENCRYPT_PROFILE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you want to remove this from the upgrade hook.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind. Moved.

@sherakama sherakama merged commit 1ef3caf into 7.x-3.x Feb 13, 2020
@sherakama sherakama deleted the DEVOPS-222 branch February 13, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants