Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create wysiwyg_landing.txt #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Create wysiwyg_landing.txt #11

wants to merge 2 commits into from

Conversation

jenbreese
Copy link
Contributor

This is a landing page to link to the created sample content.

READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

  • A sample of a landing page to show what might be new in a subtheme

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Urgency

  • How urgent is this? (Normal, High)

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to...
  4. Verify...

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

This is a landing page to link to the created sample content.
Copy link
Member

@cjwest cjwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jen!

I've tried to include ids with the headings for each example. I'm thinking we can add the anchors in here?

Would you like to give add them? If not I'm happy to do that.

@jenbreese
Copy link
Contributor Author

Hi @cjwest How is this?

@cjwest
Copy link
Member

cjwest commented Apr 28, 2023

Those ids will make it easier to link to. Thank you.

In looking at it, I do have another question: Under some headings you have a list with at least one item, under other headings you have an empty list, and under other headings you have no list. For the existing list, I would imagine I simply insert the URL. For the others, what are you expecting?

I guess I'm wondering if it would make more sense to have a list and an example link under each?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants