fix(atom/button): avoid following the link if link button is disabled #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oriolpuig
requested review from
carlosvillu,
jcger,
kikoruiz and
midudev
as code owners
| @@ -17,7 +17,7 @@ const Button = ({ | |||
| return link ? ( | |||
| <Link | |||
| {...attrs} | |||
| href={href} | |||
| href={!disabled && href} | |||
There was a problem hiding this comment.
Corrigeme si me equivoco pero si disabled es false el valor de la prop href seria false?
There was a problem hiding this comment.
No, si disabled=false el resultado de la condición será true y, por tanto, el atributo href tendrá el valor de la propiedad href
There was a problem hiding this comment.
Pero cuando disabled es true la prop href tendrá valor false. El enlace del componente tendrá href=false?
There was a problem hiding this comment.
Cuando la prop href es false, el atributo no existirá.
There was a problem hiding this comment.
merci. Me lian a veces los short circuits
adriadoz
approved these changes
Nov 14, 2019
midudev
approved these changes
Nov 14, 2019
giodelabarrera
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue (#387):
If an
atom-buttontype link is disabled, the link still works.Expected behavior:
If an
atom-buttontype link is disabled, the link shouldn't work.Solution:
We can prevent the link navigation using the
disabledprop of theatom-button.