Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrieval of locale answers #3

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Conversation

PapaDragonov
Copy link
Contributor

Getting localized answers is not possible since getFaq() does not return the correct value. This can be fixed (and the method can be simplified) by these changes.

Getting localized answers is not possible since getFaq() does not return the correct value. This can be fixed (and the method can be simplified) by these changes.
@SUKOHI SUKOHI merged commit 12f367c into SUKOHI:master Jan 30, 2018
@SUKOHI
Copy link
Owner

SUKOHI commented Jan 30, 2018

Hi, PapaDragonov.
Yes, what you're saying is absolutely correct.
However, I will change your code a little because Laravel 5.4 or less doesn't have firstWhere() method.

But I appreciate your help.
Thank you!

@SUKOHI
Copy link
Owner

SUKOHI commented Jan 30, 2018

I added your name as a contributor in README.md.
If you mind that, please let me know.
Thank you!

@PapaDragonov PapaDragonov deleted the patch-1 branch January 30, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants