Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#66 linux relay #69

Merged
merged 35 commits into from
May 22, 2024
Merged

#66 linux relay #69

merged 35 commits into from
May 22, 2024

Conversation

Goral64
Copy link
Contributor

@Goral64 Goral64 commented May 12, 2024

Added control elements as CustomRelay. They contain output elements: Cmd, File and MQTT within template: Simple and Json

@Goral64 Goral64 marked this pull request as draft May 12, 2024 18:02
@Goral64 Goral64 marked this pull request as ready for review May 15, 2024 15:26
Copy link
Member

@klew klew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When device work normally, and connection with broker is interrupted, and then when I try to change relay state, whole sd4linux is halted for ~30 s (reconnect timeout on MQTT).
Connection state to MQTT should not affect other sd4linux functionalities.
This reconnect timeout should be modified, so on few first connection problems, it should reconnect quicker and then if it still fails, it should use longer timeout.

extras/examples/linux/README.md Outdated Show resolved Hide resolved
extras/examples/linux/README.md Outdated Show resolved Hide resolved
extras/examples/linux/README.md Show resolved Hide resolved
extras/examples/linux/README.md Show resolved Hide resolved
extras/examples/linux/README.md Outdated Show resolved Hide resolved
extras/porting/linux/supla/source/mqtt_src.cpp Outdated Show resolved Hide resolved
extras/porting/linux/supla/source/mqtt_src.cpp Outdated Show resolved Hide resolved
extras/porting/linux/supla/source/mqtt_src.h Show resolved Hide resolved
extras/examples/linux/README.md Show resolved Hide resolved
extras/examples/linux/README.md Outdated Show resolved Hide resolved
@Goral64 Goral64 mentioned this pull request May 16, 2024
Copy link
Member

@klew klew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nadal po wyłączeniu brokera i próbie sterowania przekaźnikiem, cała aplikacja jest blokowana i nic się nie reaguje na inne wiadomości.

extras/porting/linux/mqtt_client.h Show resolved Hide resolved
@Goral64
Copy link
Contributor Author

Goral64 commented May 21, 2024

Nadal po wyłączeniu brokera i próbie sterowania przekaźnikiem, cała aplikacja jest blokowana i nic się nie reaguje na inne wiadomości.

Poprawiłem, mam nadzieję, że wystarczy.

@Goral64 Goral64 requested a review from klew May 21, 2024 16:01
@klew klew merged commit 066ac91 into SUPLA:main May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants