testsetup: Check for DNS working inside VMs #1660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To our surprise we learned yesterday that in some occassions DNS lookups ot the outside is not working with Cloud7, and we seem to have no check for that. Adding a test for this
|
There was a check for that in line 3884, but at some point I pointed that to $clouddata which happened to be an IP resolved outside of the VM. |
bmwiedemann
reviewed
Feb 3, 2017
| @@ -3915,6 +3916,9 @@ function oncontroller_testsetup | |||
| ssh $ssh_target fdisk -l $device | grep 1073741824 || volumeattachret=57 | |||
| ssh $ssh_target "mount $device /mnt && grep -q $rand /mnt/test.txt" || volumeattachret=58 | |||
| volumeresult="$volumecreateret & $volumeattachret" | |||
|
|
|||
| # Check for DNS available inside instances | |||
| ssh $ssh_target getent hosts www.google.com || dnsresult=59 | |||
There was a problem hiding this comment.
Would fail when deploying an offline cloud. might be nicer to do it thus #1661
bmwiedemann
requested changes
Feb 3, 2017
| echo "Ports in binding_failed: $portresult" | ||
|
|
||
| test $tempestret = 0 -a $volumecreateret = 0 -a $volumeattachret = 0 \ | ||
| -a $radosgwret = 0 -a $portresult = 0 || exit 102 | ||
| -a $radosgwret = 0 -a $volumeresult = 0 -a $portresult = 0 || exit 102 |
There was a problem hiding this comment.
$dnsresult should be checked here?
|
PR #1661 was merged, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To our surprise we learned yesterday that in some occassions
DNS lookups ot the outside is not working with Cloud7, and we
seem to have no check for that. Adding a test for this