New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testsetup: Check for DNS working inside VMs #1660
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3893,6 +3893,7 @@ function oncontroller_testsetup | |
local volumeattachret=0 | ||
local volumeresult="" | ||
local portresult=0 | ||
local dnsresult=0 | ||
|
||
# do volume tests for non-docker scenario only | ||
if [ -z "$want_docker" ] ; then | ||
|
@@ -3915,6 +3916,9 @@ function oncontroller_testsetup | |
ssh $ssh_target fdisk -l $device | grep 1073741824 || volumeattachret=57 | ||
ssh $ssh_target "mount $device /mnt && grep -q $rand /mnt/test.txt" || volumeattachret=58 | ||
volumeresult="$volumecreateret & $volumeattachret" | ||
|
||
# Check for DNS available inside instances | ||
ssh $ssh_target getent hosts www.google.com || dnsresult=59 | ||
else | ||
volumeresult="tests skipped (not supported for docker)" | ||
fi | ||
|
@@ -3999,10 +4003,11 @@ function oncontroller_testsetup | |
echo "RadosGW Tests: $radosgwret" | ||
echo "Tempest: $tempestret" | ||
echo "Volume in VM: $volumeresult" | ||
echo "DNS inside VM: $dnsresult" | ||
echo "Ports in binding_failed: $portresult" | ||
|
||
test $tempestret = 0 -a $volumecreateret = 0 -a $volumeattachret = 0 \ | ||
-a $radosgwret = 0 -a $portresult = 0 || exit 102 | ||
-a $radosgwret = 0 -a $volumeresult = 0 -a $portresult = 0 || exit 102 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. $dnsresult should be checked here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. d'oh, yea. |
||
} | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would fail when deploying an offline cloud. might be nicer to do it thus #1661