Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

galleryimg command #39

Merged
merged 23 commits into from
Jun 16, 2022
Merged

galleryimg command #39

merged 23 commits into from
Jun 16, 2022

Conversation

apozsuse
Copy link
Contributor

Command for galleryimg management

  • Includes 3 subcommands for existence check, creation and deletion of a galleryimg
  • Update of the README.md and the unit tests accordingly

Remarks

Due to the Azure SDK replying always None for the result of the async delete operation, it's not possible to provide more accurate info for the user about the image deletion (without implementing some logic). This issue has been created to revisit this behavior in the future.

@apozsuse
initial commit
8f0a2bf
@apozsuse
saving changes
9245df5
@apozsuse
Initial commmit for azure-img-tools CLI
c747cf8
@apozsuse
Improving test coverage
70d9e2c
@apozsuse
Changes:
51c2cd5 
  - Fixing some of the comments of the PR in the README.md file
  - Moved the blob management subcommands into blob command rather than
    image command.
@apozsuse
Changes:
1e7efac 
- removing unrequired authentication options in the CLI (just
leavina authentication with credentials.json file)
- added confirmation options for delete
@apozsuse
Changes:
9af254a 
- Added container and resource-group as shared params
- fixed tests accordingly
- fixed bug in upload_image_blob kwargs
- fixed typos/ improved comments in README.md file
@apozsuse
including missing test file for config
582f0f2
@apozsuse
Changes:
0a6562f 
- create image group of commands
- implement image exists subcommand
- Update README and tests accordingly
@apozsuse
Changes:
10448a1 
- Added image delete command
- Updated README and tests accordingly
- Fixed minor bug in blob delete command (logging error)
@apozsuse
Changes:
79df4ad 
- Added image create command
- Updated README and tests files accordingly
- Fixed some typos in blob command tests
@apozsuse
testing image commands
005a852
@apozsuse
Merge branch 'main' into image_exists_command
097c67f
@apozsuse
Changes:
d923b8c 
Modifying the behavior of some commands due to the sdk not properly
providing the result object for an async operation.
@apozsuse
README adjustments
62d9aca
@apozsuse
adding gallery commands to cli
847c223
@apozsuse
Merge branch 'main' into gallery_command
64fff8b
@apozsuse
Including tests
cf9f189
@apozsuse
fixing typos
f847a12
@apozsuse
README.md update
a35ee4e
smarlowucf
smarlowucf requested changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@smarlowucf smarlowucf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I think we want to be clear with naming.

README.md Outdated Show resolved Hide resolved
azure_img_utils/cli/galleryimg.py Outdated Show resolved Hide resolved
azure_img_utils/cli/galleryimg.py Outdated Show resolved Hide resolved
@apozsuse apozsuse requested a review from smarlowucf June 14, 2022 09:46
rjschwei
rjschwei requested changes Jun 16, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
azure_img_utils/cli/gallery_image_version.py Outdated Show resolved Hide resolved
@apozsuse apozsuse merged commit 99aa9a1 into main Jun 16, 2022
@apozsuse apozsuse deleted the gallery_command branch June 16, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjschwei rjschwei rjschwei approved these changes

@smarlowucf smarlowucf smarlowucf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apozsuse @rjschwei @smarlowucf