avoid loading local customization in the test environment #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanotorresi
force-pushed
the
avoid-customization-in-tests
branch
2 times, most recently
from
181631d
to
5e08496
Compare
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 645 645
=========================================
Hits 645 645 Continue to review full report at Codecov.
|
|
I prefer the alternative you posted in the description; in general I'd prefer the test suite bend over backwards to fit the app, rather than modifying the app for testing convenience. |
stefanotorresi
force-pushed
the
avoid-customization-in-tests
branch
from
5e08496
to
90c6e8a
Compare
move the test customizer setting after Rails is loaded avoid implicit conversion error cs fix
stefanotorresi
force-pushed
the
avoid-customization-in-tests
branch
from
799522b
to
9f58564
Compare
|
@bear454 makes total sense! Updated accordingly. |
bear454
approved these changes
Nov 11, 2020
|
This bit me yesterday, in testing the top menu. Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the proper way to go about this, but I don't think the tests should be affected by local customizations.
Another approach could be to set
BLUE_HORIZON_CUSTOMIZERto a checked-in file, dedicated to the test environment, but there are no actual customization needed at the moment. I guess we could just put an empty json file somewhere, though.I'm open to suggestions!