Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry attempts #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add retry attempts #14

wants to merge 1 commit into from

Conversation

jesusbv
Copy link
Collaborator

@jesusbv jesusbv commented Apr 26, 2024

Add 3 retry attempts for the query to the server, in case of network issue or any order problem that could interfere with the request

@jesusbv jesusbv requested a review from schaefi April 26, 2024 14:14
@jesusbv jesusbv self-assigned this Apr 26, 2024
@jesusbv jesusbv requested a review from rjschwei April 26, 2024 14:14
@jesusbv jesusbv force-pushed the add-retry-attempts branch 3 times, most recently from 93ce134 to 590c81d Compare April 26, 2024 14:51
When making the request to the update infrastructure server
try best effort to get the billing check info
Default to make 3 requests
@jesusbv
Copy link
Collaborator Author

jesusbv commented Apr 26, 2024

I had a conversation with @mcalmer about how SUMa is called, @rjschwei was right
Despite previous conversations regarding the option to be configurable with the SUMa team,
SUMa calls the instance-flavor-check command the same way every time

No need to configure the option, it is a default value

@jesusbv jesusbv changed the title Add retry attempts option Add retry attempts May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant