[DNM] [SES5] qa: add --apparmor option to all test scripts #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
changed the title
jan--f
reviewed
Mar 26, 2018
qa/suites/basic/health-rgw.sh
Outdated
| CLI="" | ||
| SSL="" | ||
| while true ; do | ||
| case "$1" in | ||
| --cli) CLI="cli" ; shift ;; |
There was a problem hiding this comment.
This deletion seems to be an accident?
smithfarm
force-pushed
the
wip-qa-apparmor
branch
from
42d33c1
to
d364100
Compare
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>
smithfarm
force-pushed
the
wip-qa-apparmor
branch
from
d364100
to
8bb6056
Compare
jan--f
approved these changes
Mar 26, 2018
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>
jan--f
reviewed
Mar 27, 2018
qa/common/common.sh
Outdated
| @@ -430,6 +430,7 @@ EOF | |||
| function ceph_apparmor { | |||
| salt '*' state.apply ceph.apparmor | |||
| salt '*' cmd.run 'systemctl | grep -i apparmor' | |||
| salt '*' cmd.run '/usr/sbin/apparmor_status' | |||
There was a problem hiding this comment.
Imho it would be better to use /usr/sbin/aa-status here. /usr/sbin/apparmor_status is a symlink to aa-status...might be suse specific..?
There was a problem hiding this comment.
So use aa-status here, too?
DeepSea/srv/modules/runners/ready.py
Line 74 in d8a1c2d
There was a problem hiding this comment.
yeah thats probably a good idea as well.
edit: I'm on it.
smithfarm
changed the title
apparmor_status is just a symlink to aa-status, so use the latter. Signed-off-by: Nathan Cutler <ncutler@suse.com>
|
This is still set to DNM. Also, I thought we had a smoketest for apparmor on the horizon. |
|
we should close that. any objections @smithfarm ? |
|
closing in favor of apparmor coverage in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$SUBJ is self-explanatory