Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Extend version info on Web page #1023

Closed
holgerreif opened this issue Aug 8, 2016 · 3 comments
Closed

Extend version info on Web page #1023

holgerreif opened this issue Aug 8, 2016 · 3 comments

Comments

@holgerreif
Copy link

Admin user gets version (like 2.1.0-dev) info at the lower right corner, normal user doesn't.

Admin user should get a detailed version (meaning for a -dev release the number and date of latest commit should be displayed as well) and the normal user should get the short version.

Rationale: admin could easily check what actual version is deployed (esp. if pulled as a prebuild image), user could at least get a glue which online documenation is relevant to his version.

@mssola
Copy link
Collaborator

mssola commented Aug 8, 2016

Admin user should get a detailed version (meaning for a -dev release the number and date of latest commit should be displayed as well) and the normal user should get the short version.

This is already happening, no ? At least from current master I get Version: master@5a698eac9d55. Isn't that the same for you ? How are you deploying Portus. As far as I remember, 2.1.0-dev will only be shown if there is no git info on the deployed Portus.

user could at least get a glue which online documenation is relevant to his version.

Agreed, we should allow regular users to check at least the current version.

@holgerreif
Copy link
Author

We are using the latest Image from dockerhub containng RPM with the last but one commit from master (last commit failed to build on OBS).

Admin gets the following displayed: 4ff612e8beeddf5f

@mssola
Copy link
Collaborator

mssola commented Aug 9, 2016

I see, if I recall correctly we strip git info when producing the RPM, so that's why you are getting that version. I'll take a look at this too 😉

vitoravelino added a commit to vitoravelino/Portus that referenced this issue Feb 22, 2017
Signed-off-by: Vítor Avelino <contact@vitoravelino.me>
@mssola mssola added this to the Release 2.3 milestone Aug 2, 2017
mssola added a commit to mssola/Portus that referenced this issue Jan 4, 2018
This way Portus will be able to tell the git commit of the current
version.

Fixes SUSE#1023

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants