This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Set JWT auth token "sub" field by basic auth username instead of "account" HTTP GET parameter #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ount" HTTP GET parameter Signed-off-by: Christoph Honal <christoph.honal@web.de>
This was referenced Feb 19, 2020
|
Note: #2274 Also fixes this issue. |
|
Thanks for all your contributions! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the specification and the authors of containerd the
accountGET parameter when requesting a JWT auth token is invalid (Even though docker-cli does it) and the HTTP basic auth username should be used instead. For example, Docker BuildX via buildkit via containerd does not set this parameter, resulting in Portus being confused.This pull request fixes this behaviour by using the HTTP auth username.
Signed-off-by: Christoph Honal christoph.honal@web.de