Add compatibility note to mysql sidecar README #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HartS
force-pushed
the
harts-document-mysql-sidecar-compatibility
branch
from
52508cd
to
b1a6ac3
Compare
|
We might want to drop a reference to the underlying issue, go-sql-driver/mysql#785 |
HartS
force-pushed
the
harts-document-mysql-sidecar-compatibility
branch
from
b1a6ac3
to
486eb73
Compare
|
@mook-as this is done now |
mook-as
approved these changes
Aug 3, 2018
There was a problem hiding this comment.
Looks like go-sql-driver/mysql 1.4.0 fixes this; we need to bump the vendored package to get the fix. In the mean time, we can merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.