Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround system cert reloading after import (bsc#1195220) #118

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

skazi0
Copy link
Contributor

@skazi0 skazi0 commented Feb 4, 2022

This is a workaround for Golang's missing feature of reloading system certs.
The built in system certs pool is initialized only once on startup and there is no option for reloading it when new certs are installed.
The problem is known upstream and tracked at golang/go#41888.
The cert_pool.go is almost 1:1 copy of original library code but exposes needed functionality. It can be removed when upstream fixes the problem.

This is a workaround for Golang's missing feature of reloading system
certs.
The built in system certs pool is initialized only once on startup and
there is no option for reloading it when new certs are installed.
The problem is known upstream and tracked at
golang/go#41888.
The cert_pool.go is almost 1:1 copy of original library code but exposes
needed functionality. It can be removed when upstream fixes the problem.
@skazi0 skazi0 requested a review from djoreilly February 4, 2022 15:03
@skazi0 skazi0 changed the title Extract setupHTTPClient for easier reuse Workaround system cert reloading after import (bsc#1195220) Feb 4, 2022
Copy link
Collaborator

@djoreilly djoreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants