Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self from LD_PRELOAD (bsc#1196326) #123

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Conversation

skazi0
Copy link
Contributor

@skazi0 skazi0 commented Mar 2, 2022

The libsuseconnect library will remove itself from LD_PRELOAD variable
after loading. This will prevent child processes started from
libsuseconnect and/or from the host program from needlessly preloading
libsuseconnect again.

The libsuseconnect library will remove itself from LD_PRELOAD variable
after loading. This will prevent child processes started from
libsuseconnect and/or from the host program from needlessly preloading
libsuseconnect again.
@skazi0 skazi0 marked this pull request as ready for review March 2, 2022 13:05
Copy link
Collaborator

@djoreilly djoreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skazi0 skazi0 merged commit 4af5a2b into SUSE:main Mar 3, 2022
@skazi0 skazi0 deleted the un-preload branch March 3, 2022 14:21
@ancorgs
Copy link

ancorgs commented Mar 3, 2022

Just for the record, this is a (not so nice) workaround for the unwanted side-effect of yast/yast-yast2#1236, which is admittedly another workaround.

This should do the job for SLE-15-SP4, but ideally we should find a better solution that would save us from messing around with LD_PRELOAD (ie. that would allow us to revert this commit and the corresponding one in yast-yast2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants