-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preload libsuseconnect.so if available (bsc#1194996) #1236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch @skazi0!
I have asked review from some other members in the team with better knowledge than me in that area. Meanwhile, do you mind bumping version and updating the changelog? It is just a matter of following instructions given in the 4th step at https://yastgithubio.readthedocs.io/en/latest/contributing/#code-changes 😀
Of course, I can help if needed after it got reviewed and approved, but it would be nice if you at least give it a try 😉
On aarch64 installer/YaST sometimes failed to load libsuseconnect.so with "cannot allocate memory in static TLS block" error. Loading the library before others solves the problem until a better solution is found.
3cbd9b6
to
6a14acd
Compare
@dgdavid done (and sorry for not reading the contributing guide before). |
Thanks!
No problem at all 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! (workaround)
✔️ Public Jenkins job #353 successfully finished |
✔️ Internal Jenkins job #190 successfully finished |
BTW from pytorch/builder#758 (comment) I guess that a possible solution is to not preallocate memory within libsuseconnect. But I don't know its implementation details. |
@mvidner see my comments on https://bugzilla.suse.com/show_bug.cgi?id=1194996 |
It seems this PR is causing quite some issues, e.g., https://bugzilla.suse.com/show_bug.cgi?id=1196326 |
Since this causes follow-up problems, we decided to revert this. https://bugzilla.suse.com/show_bug.cgi?id=1196326 https://bugzilla.suse.com/show_bug.cgi?id=1194996#c11
|
On aarch64 installer/YaST sometimes failed to load libsuseconnect.so
with "cannot allocate memory in static TLS block" error.
Loading the library before others solves the problem until a better
solution is found.