fixes for rubocop

SUSE · Sep 29, 2017 · 09e6b1a · 09e6b1a
1 parent 9858e20
commit 09e6b1a
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -101,6 +101,14 @@ Lint/IneffectiveAccessModifier:
   Exclude:
     - 'lib/suse/connect/credentials.rb'
 
+Lint/RescueWithoutErrorClass:
+  Exclude:
+    - 'lib/suse/connect/hwinfo/arm64.rb'
+    - 'lib/suse/connect/hwinfo/x86.rb'
+    - 'lib/suse/toolkit/curlrc_dotfile.rb'
+    - 'lib/suse/toolkit/utilities.rb'
+    - 'bin/SUSEConnect'
+
 # Offense count: 4
 # Cop supports --auto-correct.
 Lint/UnneededDisable:

diff --git a/lib/suse/connect/connection.rb b/lib/suse/connect/connection.rb
@@ -36,7 +36,7 @@ def initialize(endpoint, language: nil, insecure: false, debug: false, verify_ca
         self.verify_callback = verify_callback
       end
 
-      VERB_TO_CLASS.keys.each do |name_for_method|
+      VERB_TO_CLASS.each_key do |name_for_method|
         define_method name_for_method do |path, auth: nil, params: {}|
           @auth = auth
           response = json_request(name_for_method.downcase.to_sym, path, params)

diff --git a/lib/suse/connect/errors.rb b/lib/suse/connect/errors.rb
@@ -19,7 +19,7 @@ class BaseProductDeactivationError < StandardError; end
     # Used by YaST already, do not refactor without consulting them!
     # (Error handling: #response, #code, #message, #service)
     class ApiError < StandardError
-      attr_accessor :response, :message
+      attr_accessor :response
 
       # @param response [Net::HTTPResponse] the HTTP response error returned
       # by API request

diff --git a/prophet/ci_executor.rb b/prophet/ci_executor.rb
@@ -29,7 +29,7 @@ def text_status
   # Project
   class Project
 
-    attr_accessor :name, :steps, :status
+    attr_accessor :name, :steps
 
     def initialize(name: nil, steps: [])
       @name = name