Make the package search API throw an UnsupportedOperation error if request returns 404 #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergeykot
reviewed
Jun 8, 2018
spec/connect/errors_spec.rb
Outdated
|
|
||
| describe '.message' do | ||
| it 'returns the http message' do | ||
| expect(described_class.new(with_http_message).message).to eq 'foo' |
There was a problem hiding this comment.
I would use parentheses here and below
There was a problem hiding this comment.
I had too open this pull request which is based on #372 against master since prophet does not allow any other branches as base branch!
wstephenson
reviewed
Jun 11, 2018
lib/suse/connect/api.rb
Outdated
| rescue ApiError => e | ||
| raise e if e.code != 404 | ||
| raise UnsupportedOperation, 'Package search is not supported by the '\ | ||
| 'registration proxy: Alternatively checkout'\ |
There was a problem hiding this comment.
s/Alternatively checkout/Alternatively, use/
wstephenson
reviewed
Jun 11, 2018
| end | ||
| end | ||
|
|
||
| context 'not working host' do |
wstephenson
reviewed
Jun 11, 2018
spec/connect/errors_spec.rb
Outdated
| ) | ||
| end | ||
|
|
||
| describe '.code' do |
There was a problem hiding this comment.
is already fixed in the other PR. I had to open the pull request against master otherwise prophet is not running :)
wstephenson
reviewed
Jun 11, 2018
spec/connect/errors_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| describe '.message' do |
felixsch
force-pushed
the
add-unsupported-operation
branch
from
456b819
to
588d9fb
Compare
wstephenson
reviewed
Jun 11, 2018
|
Well Done! Your tests are still passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.