New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[readme] Add submiting packages instruction #391
Conversation
06d6207
to
a0fe833
Compare
PACKAGE.md
Outdated
To get a maintenance request accepted, each changelog entry needs to reference a bug or feature | ||
request with `bsc#123` or `fate#123`. | ||
Note: If you want to disable automatic changes made by osc (e.g. License string) | ||
use the `--no-cleanup` switch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not keep this --no-cleanup
option with the commands where it's applicable, and just add a note explaining what it does? Otherwise it's not easy to know exactly which osc
commands take this option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea here is: Using --no-cleanup
by default removes the good side of the script, like cleaning up and removing deprecated patterns. From my perspective I think the default should be running the commands with the cleanup and only in special cases don't use them (e.g. the license chaning)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it's there's no easy way to know which osc
subcommands even accept the --no-cleanup
option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe: "use the --no-cleanup
switch for the osc sr
and osc mr
calls"
PACKAGE.md
Outdated
``` | ||
|
||
### SLES (Internal Build Service) | ||
### Submit packages to the Internal Build Service (SLES) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better:
### Submit maintenance updates for SLES to the Internal Build Service
a0fe833
to
a9424b6
Compare
Well Done! Your tests are still passing. |
No description provided.