Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readme] Add submiting packages instruction #391

Merged
merged 1 commit into from Oct 1, 2018

Conversation

felixsch
Copy link
Contributor

No description provided.

@felixsch felixsch force-pushed the update-packaging-readme branch 2 times, most recently from 06d6207 to a0fe833 Compare September 24, 2018 11:11
@SUSE SUSE deleted a comment from suse-tests-pass Sep 24, 2018
PACKAGE.md Outdated
To get a maintenance request accepted, each changelog entry needs to reference a bug or feature
request with `bsc#123` or `fate#123`.
Note: If you want to disable automatic changes made by osc (e.g. License string)
use the `--no-cleanup` switch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep this --no-cleanup option with the commands where it's applicable, and just add a note explaining what it does? Otherwise it's not easy to know exactly which osc commands take this option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea here is: Using --no-cleanup by default removes the good side of the script, like cleaning up and removing deprecated patterns. From my perspective I think the default should be running the commands with the cleanup and only in special cases don't use them (e.g. the license chaning)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's there's no easy way to know which osc subcommands even accept the --no-cleanup option.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe: "use the --no-cleanup switch for the osc sr and osc mr calls"

PACKAGE.md Outdated
```

### SLES (Internal Build Service)
### Submit packages to the Internal Build Service (SLES)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better:
### Submit maintenance updates for SLES to the Internal Build Service

@SUSE SUSE deleted a comment from suse-tests-pass Oct 1, 2018
@suse-tests-pass
Copy link
Collaborator

Well Done! Your tests are still passing.
https://ci.suse.de/job/SCC-Connect-Prophet/148395/console
If the given link has expired,you can force a Prophet rerun by just deleting this comment. (Merged a9424b6 into 7e867d6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants