Fix dmidecode not installed #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lagartoflojo
commented
Oct 22, 2018
•
lagartoflojo
commented
- Bump the version
- :each is not needed when calling before/after, since it's the default - Removed duplication on `context` and `it` descriptions - Renamed `dmidecode` to `dmidecode_output` to make it clearer - Moved the `dmidecode_output` variable to the block where it is used
Not all systems have dmidecode installed. When they don't, calling HwInfo#cloud_provider failed with "No such file or directory - dmidecode". Now, we correctly rescue from Errno::ENOENT errors, and return nil. This means that, at least for now, we do not detect S390 systems running in the public cloud, although it's unknown whether there is any cloud provider that offers that architecture. Bug: https://bugzilla.suse.com/show_bug.cgi?id=1112702
|
Well Done! Your tests are still passing. |
digitaltom
approved these changes
Oct 22, 2018
|
Well Done! Your tests are still passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.