manpage improvements, remove incorrect mention of HTTPS_PROXY ENV #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lagartoflojo
reviewed
Jul 8, 2019
SUSEConnect.8.ronn
Outdated
| server using a RESTful JSON API over HTTP using TLS encryption. | ||
|
|
||
| ## ENVIRONMENT | ||
| SUSEConnect respects the HTTP_PROXY and HTTPS_PROXY environment variables. | ||
| SUSEConnect uses Net::HTTP for its requests and respects the HTTP_PROXY environment variable. |
There was a problem hiding this comment.
Do you think it's necessary to mention "uses Net::HTTP for its requests"? It seems more like an implementation detail to me, not sure if it's relevant for users.
lagartoflojo
approved these changes
Jul 8, 2019
|
Well Done! Your tests are still passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.