Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing on registered system without arguments #421

Merged
merged 3 commits into from Aug 7, 2019

Conversation

gionaufal
Copy link
Contributor

@gionaufal gionaufal commented Aug 7, 2019

Trello card

The solution was to remove the status check, and also to introduce a check for the product param that was not being verified and is needed for products that don't require a regcode.

@SUSE SUSE deleted a comment from suse-tests-pass Aug 7, 2019
@SUSE SUSE deleted a comment from suse-tests-pass Aug 7, 2019
@suse-tests-pass
Copy link
Collaborator

Well Done! Your tests are still passing.
https://ci.suse.de/job/SCC-Connect-Prophet/230404/console
If the given link has expired,you can force a Prophet rerun by just deleting this comment. (Merged ca6c062 into 9bc7691)

Copy link
Contributor

@josegomezr josegomezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@gionaufal gionaufal merged commit eaa58be into master Aug 7, 2019
@lagartoflojo lagartoflojo deleted the fix-failing-registered branch October 14, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants