Forbid de-registration for on-demand Public Cloud instances #431
Conversation
ikapelyukhin
force-pushed
the
forbid-deregistration-on-payg-instances
branch
from
aad5385
to
350f805
Compare
ikapelyukhin
force-pushed
the
forbid-deregistration-on-payg-instances
branch
from
350f805
to
6f26802
Compare
|
Well Done! Your tests are still passing. |
| if File.exist?('/usr/sbin/registercloudguest') | ||
| raise UnsupportedOperation, | ||
| 'De-registration is disabled for on-demand instances. Use `registercloudguest --clean` instead.' | ||
| end |
There was a problem hiding this comment.
Did you check how deregistration with yast will fail in this case?
There was a problem hiding this comment.
@digitaltom I don't think Yast has de-registration functionality at all.
There was a problem hiding this comment.
https://github.com/yast/yast-registration/blob/master/src/lib/registration/ui/registered_system_dialog.rb#L43-L44 -- this advice sounds weird.
There was a problem hiding this comment.
Hmm that message assumes that users have at least cloud-regionsrv-client 9.0.6. I suppose it is fair to assume that someone that picks up the new version of SUSEConnect also updated the cloud-regionsrv-client package. I am OK making the connection, just wanted to note that it exists.
There was a problem hiding this comment.
@rjschwei yep, I though about this as well, but the alternative to --clean would be manual clean up and I'm not sure how explain that in a short error message.
But as long as modules aren't removed, I guess this should be fine.
| if File.exist?('/usr/sbin/registercloudguest') | ||
| raise UnsupportedOperation, | ||
| 'De-registration is disabled for on-demand instances. Use `registercloudguest --clean` instead.' | ||
| end |
There was a problem hiding this comment.
Hmm that message assumes that users have at least cloud-regionsrv-client 9.0.6. I suppose it is fair to assume that someone that picks up the new version of SUSEConnect also updated the cloud-regionsrv-client package. I am OK making the connection, just wanted to note that it exists.
|
|
||
| context 'when running on on-demand instance' do | ||
| before do | ||
| allow(File).to receive(:exist?).and_call_original |
There was a problem hiding this comment.
Shouldn't this be treated as an expect?
There was a problem hiding this comment.
Depends on your view on whether expectations should be allowed in before block. Rubocop complains about that, though.
De-registration removes product release packages, which prevents automatic re-registration of modules.
registercloudguestshould be used on on-demand instances instead.