Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YaST package search #434

Merged
merged 5 commits into from Aug 26, 2020
Merged

YaST package search #434

merged 5 commits into from Aug 26, 2020

Conversation

imobachgs
Copy link
Member

This PR extends the YaST API to access to the package search functionality. It is needed in order to implement the online search feature.

@lagartoflojo
Copy link
Contributor

Hey @imobachgs, we just noticed this PR. Is it needed for 15 SP2?

@imobachgs
Copy link
Member Author

imobachgs commented Apr 21, 2020

@lagartoflojo It would be a nice improvement, but it can wait until SP3. After all, the online feature is already finished and I guess we will not introduce new changes unless it is strictly needed. Thanks a lot!

@lagartoflojo
Copy link
Contributor

I've added it to our backlog so we review it once we get a chance. We're super busy with the Day 2 migration right now :(

@ngetahun
Copy link
Contributor

@imobachgs Can you please resolve the merge conflict?

@ngetahun ngetahun self-requested a review August 24, 2020 14:44
@ngetahun
Copy link
Contributor

package/SUSEConnect.changes Outdated Show resolved Hide resolved
Copy link
Contributor

@ngetahun ngetahun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imobachgs
Copy link
Member Author

LGTM!

Thanks a lot!

@ngetahun ngetahun merged commit 1c8c9c6 into SUSE:master Aug 26, 2020
@imobachgs imobachgs deleted the yast-package-search branch August 27, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants