Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace env ruby with native path #449

Merged
merged 2 commits into from Nov 17, 2020
Merged

Conversation

tamara-schmitz
Copy link

builds in home branch on OBS succeeded.

Addresses a packaging guideline.

builds in home branch on OBS succeeded.
@felixsch
Copy link
Contributor

Good job! Since we want to release the changes, can bump the version (patch) and add a changelog entry. Is there a bug open for this problem? If yes, make sure to reference it from your changelog entry.

@tamara-schmitz
Copy link
Author

tamara-schmitz commented Nov 17, 2020

Since we want to release the changes, can bump the version (patch) and add a changelog entry.

Sure. Will do.

Is there a bug open for this problem?

Good question

@SUSE SUSE deleted a comment from suse-tests-pass Nov 17, 2020
@suse-tests-pass
Copy link
Collaborator

Well Done! Your tests are still passing.
https://ci.suse.de/job/SCC-Connect-Prophet/362772/console
If the given link has expired,you can force a Prophet rerun by just deleting this comment. (Merged 41c1805 into ff798ab)

Copy link
Contributor

@felixsch felixsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@tamara-schmitz tamara-schmitz merged commit 324403b into master Nov 17, 2020
@tamara-schmitz tamara-schmitz deleted the ruby_ver_replace_in_spec branch November 17, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants