Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gpg check errors #455

Merged
merged 3 commits into from Apr 16, 2021
Merged

Fix gpg check errors #455

merged 3 commits into from Apr 16, 2021

Conversation

ngetahun
Copy link
Contributor

No description provided.

Copy link
Contributor

@Sergeykot Sergeykot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment otherwise LGTM 👍

Dockerfile.15sp0 Outdated Show resolved Hide resolved
@ngetahun
Copy link
Contributor Author

Dockerfile.15sp0 Outdated
Comment on lines 8 to 10
RUN zypper ar -G http://download.suse.de/ibs/SUSE:/SLE-15:/GA/standard/ sles-pool &&\
zypper ar -G http://download.suse.de/ibs/SUSE:/SLE-15:/Update/standard/ sles-updates &&\
zypper --non-interactive --gpg-auto-import-keys ref &&\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use the real repos from the sles module structure here, so we are closer to reality.
Also those don't fail the repo validation:

Suggested change
RUN zypper ar -G http://download.suse.de/ibs/SUSE:/SLE-15:/GA/standard/ sles-pool &&\
zypper ar -G http://download.suse.de/ibs/SUSE:/SLE-15:/Update/standard/ sles-updates &&\
zypper --non-interactive --gpg-auto-import-keys ref &&\
RUN zypper ar http://download.suse.de/ibs/SUSE/Products/SLE-Module-Basesystem/15/x86_64/product base &&\
zypper ar http://download.suse.de/ibs/SUSE/Updates/SLE-Module-Basesystem/15/x86_64/update base-updates &&\
zypper ar http://download.suse.de/ibs/SUSE/Products/SLE-Module-Legacy/15/x86_64/product legacy &&\
zypper ar http://download.suse.de/ibs/SUSE/Updates/SLE-Module-Development-Tools/15/x86_64/update devtools &&\
zypper --non-interactive ref &&\

@ngetahun ngetahun merged commit acd2d79 into master Apr 16, 2021
@ngetahun ngetahun deleted the chore/ignore_gpg_check branch April 16, 2021 15:02
@ngetahun ngetahun changed the title Ignore gpg check Fix gpg check errors Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants