Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop: 0.72.0 → 0.75.1 (major) #531

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 15, 2019

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (0.72.0 → 0.75.1) · Repo · Changelog

Release Notes

0.75.1

Bug fixes

  • #7391: Support pacman formatter on Windows. (@laurenball)
  • #7407: Make Style/FormatStringToken work inside hashes. (@buehmann)
  • #7389: Fix an issue where passing a formatter might result in an error depending on what character it started with. (@jfhinchcliffe)
  • #7397: Fix extra comments being added to the correction of Style/SafeNavigation. (@rrosenblum)
  • #7378: Fix heredoc edge cases in Layout/EmptyLineAfterGuardClause. (@gsamokovarov)
  • #7404: Fix a false negative for Layout/IndentAssignment when multiple assignment with line breaks on each line. (@koic)

Changes

  • #7410: Style/FormatStringToken now finds unannotated format sequences in printf arguments. (@buehmann)
  • #6964: Set default IgnoreCopDirectives to true for Metrics/LineLength. (@jdkaplan)

0.75.0

New features

  • #7274: Add new Lint/SendWithMixinArgument cop. (@koic)
  • #7272: Show warning message if passed string to Enabled, Safe, SafeAutocorrect, and AutoCorrect keys in .rubocop.yml. (@unasuke)
  • #7295: Make it possible to set StyleGuideBaseURL per department. (@koic)
  • #7301: Add check for calls to remote_byebug to Lint/Debugger cop. (@riley-klingler)
  • #7321: Allow YAML aliases in .rubocop.yml. (@raymondfallon)
  • #7317: Add new formatter pacman. (@crojasaragonez)
  • #6075: Support IgnoredPatterns option for Naming/MethodName cop. (@koic)
  • #7335: Add todo as an alias to disable. --disable-uncorrectable will now disable cops using rubocop:todo instead of rubocop:disable. (@desheikh)

Bug fixes

  • #7256: Fix an error of Style/RedundantParentheses on method calls where the first argument begins with a hash literal. (@halfwhole)
  • #7263: Make Layout/SpaceInsideArrayLiteralBrackets properly handle tab-indented arrays. (@buehmann)
  • #7252: Prevent infinite loops by making Layout/SpaceInsideStringInterpolation skip over interpolations that start or end with a line break. (@buehmann)
  • #7262: Lint/FormatParameterMismatch did not recognize named format sequences like %.2<name>f where the name appears after some modifiers. (@buehmann)
  • #7253: Fix an error for Lint/NumberConversion when #to_i called without a receiver. (@koic)
  • #7271, #6498: Fix an interference between Style/TrailingCommaIn*Literal and Layout/Multiline*BraceLayout for arrays and hashes. (@buehmann)
  • #7241: Make Style/FrozenStringLiteralComment match only true & false. (@tejasbubane)
  • #7290: Handle inner conditional inside else in Style/ConditionalAssignment. (@jonas054)
  • #5788: Allow block arguments on separate lines if line would be too long in Layout/MultilineBlockLayout. (@jonas054)
  • #7305: Register Style/BlockDelimiters offense when block result is assigned to an attribute. (@mvz)
  • #4802: Don't leave any Lint/UnneededCopEnableDirective offenses undetected/uncorrected. (@jonas054)
  • #7326: Fix a false positive for Style/AccessModifierDeclarations when access modifier name is used for hash literal value. (@koic)
  • #3591: Handle modifier if/unless correctly in Lint/UselessAssignment. (@jonas054)
  • #7161: Fix Style/SafeNavigation cop for preserve comments inside if expression. (@tejasbubane)
  • #5212: Avoid false positive for braces that are needed to preserve semantics in Style/BracesAroundHashParameters. (@jonas054)
  • #7353: Fix a false positive for Style/RedundantSelf when receiver and multiple assigned lvalue have the same name. (@koic)
  • #7353: Fix a false positive for Style/RedundantSelf when a self receiver is used as a method argument. (@koic)
  • #7358: Fix an incorrect autocorrect for Style/NestedModifier when parentheses are required in method arguments. (@koic)
  • #7361: Fix a false positive for Style/TernaryParentheses when only the closing parenthesis is used in the last line of condition. (@koic)
  • #7369: Fix an infinite loop error for Layout/IndentAssignment with Layout/IndentFirstArgument when using multiple assignment. (@koic)
  • #7177, #7370: When correcting alignment, do not insert spaces into string literals. (@buehmann)
  • #7367: Fix an error for Style/OrAssignment cop when then branch body is empty. (@koic)
  • #7363: Fix an incorrect autocorrect for Layout/SpaceInsideBlockBraces and Style/BlockDelimiters when using multiline empty braces. (@koic)
  • #7212: Fix a false positive for Layout/EmptyLinesAroundAccessModifier and UselessAccessModifier when using method with the same name as access modifier around a method definition. (@koic)

Changes

  • #7312: Mark Style/StringHashKeys as unsafe. (@prathamesh-sonpatki)
  • #7275: Make Style/VariableName aware argument names when invoking a method. (@koic)
  • #3534: Make Style/IfUnlessModifier report and auto-correct modifier lines that are too long. (@jonas054)
  • #7261: Style/FrozenStringLiteralComment no longer inserts an empty line after the comment. This is left to Layout/EmptyLineAfterMagicComment. (@buehmann)
  • #7091: Style/FormatStringToken now detects format sequences with flags and modifiers. (@buehmann)
  • #7319: Rename IgnoredMethodPatterns option to IgnoredPatterns option for Style/MethodCallWithArgsParentheses. (@koic)
  • #7345: Mark unsafe for Style/YodaCondition. (@koic)

0.74.0

New features

  • #7219: Support auto-correct for Lint/ErbNewArguments. (@koic)

Bug fixes

  • #7217: Make Style/TrailingMethodEndStatement work on more than the first def. (@buehmann)
  • #7190: Support lower case drive letters on Windows. (@jonas054)
  • Fix the auto-correction of Lint/UnneededSplatExpansion when the splat expansion of Array.new with a block is assigned to a variable. (@rrosenblum)
  • #5628: Fix an error of Layout/SpaceInsideStringInterpolation on interpolations with multiple statements. (@buehmann)
  • #7128: Make Metrics/LineLength aware of shebang. (@koic)
  • #6861: Fix a false positive for Layout/IndentationWidth when using EnforcedStyle: outdent of Layout/AccessModifierIndentation. (@koic)
  • #7235: Fix an error where Style/ConditionalAssignment would swallow a nested if condition. (@buehmann)
  • #7242: Make Style/ConstantVisibility work on non-trivial class and module bodies. (@buehmann)

Changes

  • #5265: Improved Layout/ExtraSpacing cop to handle nested consecutive assignments. (@jfelchner)
  • #7215: Make it clear what's wrong in the message from Style/GuardClause. (@jonas054)
  • #7245: Make cops detect string interpolations in more contexts: inside of backticks, regular expressions, and symbols. (@buehmann)

0.73.0

New features

Bug fixes

  • #7170: Fix a false positive for Layout/RescueEnsureAlignment when def line is preceded with private_class_method. (@tatsuyafw)
  • #7186: Fix a false positive for Style/MixinUsage when using inside multiline block and if condition is after include. (@koic)
  • #7099: Fix an error of Layout/RescueEnsureAlignment on assigned blocks. (@tatsuyafw)
  • #5088: Fix an error of Layout/MultilineMethodCallIndentation on method chains inside an argument. (@buehmann)
  • #4719: Make Layout/Tab detect tabs between string literals. (@buehmann)
  • #7203: Fix an infinite loop error for Layout/SpaceInsideBlockBraces when EnforcedStyle: no_space with SpaceBeforeBlockParameters: false are set in multiline block. (@koic)
  • #6653: Fix a bug where Layout/IndentHeredoc would remove empty lines when autocorrecting heredocs. (@buehmann)

Changes

  • #7181: Sort analyzed file alphabetically. (@pocke)
  • #7188: Include inspected file location in auto-correction error. (@pocke)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parallel (indirect, 1.17.0 → 1.18.0) · Repo

Commits

See the full diff on Github. The new version differs by 15 commits:

↗️ parser (indirect, 2.6.3.0 → 2.6.5.0) · Repo · Changelog

Release Notes

2.6.5.0 (from changelog)

API modifications:

  • Bump ruby versions to 2.4.9, 2.5.7 and 2.6.5. (#619) (Ilya Bylich)

Features implemented:

  • lexer.rl: changed max numparam to @9 (#617) (Ilya Bylich)
  • lexer.rl: support comments before leading dot in 27 mode. (#613) (Ilya Bylich)

Bugs fixed:

  • lexer.rl: emit tMETHREF as tDOT+tCOLON for rubies < 27. (#614) (Ilya Bylich)

2.6.4.1 (from changelog)

Features implemented:

  • ruby27.y: Add kwnilarg for **nil argument (#606) (Ilya Bylich)

Bugs fixed:

  • lexer.rl: fix parsing of 'm a + b do end' (#605) (Ilya Bylich)

2.6.4.0 (from changelog)

API modifications:

  • Added specs for heredocs with mixed encoding. (#581) (Ilya Bylich)

Features implemented:

  • ruby27.y: Revert "pipeline operator" (#601) (Koichi ITO)
  • ruby27.y: Fix parsing of mutiple assignment with rescue modifier (#600) (Koichi ITO)
  • ruby27.y: hoisted out f_rest_marg. (#594) (Ilya Bylich)
  • ruby27.y: added pipeline operator. (#592) (Ilya Bylich)
  • ruby27.y: reject safe navigator in LHS of mass-assignment. (#586) (Ilya Bylich)
  • lexer.rl: reject whitespaces in meta and control chars. (#585) (Ilya Bylich)
  • lexer.rl: Reject numparams as symbol literals. (#582) (Ilya Bylich)
  • ruby27.y: Added numbered parameters support. (#565) (Ilya Bylich)
  • lexer.rl: Reject \n and \r in heredoc identifiers starting from 2.7. (#575) (Ilya Bylich)

Bugs fixed:

  • ruby-parse: print empty string when --emit-json and empty input are given. (#590) (Ilya Bylich)
  • AST_FORMAT: fixed documentation of the string with interpolation. (#589) (Ilya Bylich)
  • builder.rb, processor.rb: Changed format of the procarg0 node. (#587) (Ilya Bylich)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 31 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu
Copy link
Contributor Author

depfu bot commented Oct 29, 2019

Closed in favor of #535.

@depfu depfu bot closed this Oct 29, 2019
@depfu depfu bot deleted the depfu/update/rubocop-0.75.1 branch October 29, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants