Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rspec: 1.38.1 → 1.41.0 (minor) #639

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jul 4, 2020

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (1.38.1 → 1.41.0) · Repo · Changelog

Release Notes

1.41.0

  • Extend the list of Rails spec types for RSpec/DescribeClass. (@pirj)
  • Fix FactoryBot/AttributeDefinedStatically to allow #traits_for_enum without a block. (@harrylewis)
  • Improve the performance of FactoryBot/AttributeDefinedStatically, RSpec/InstanceVariable, RSpec/LetSetup, RSpec/NestedGroups and RSpec/ReturnFromStub. (@andrykonchin)

1.40.0

  • Add new RSpec/VariableName cop. (@tejasbubane)
  • Add new RSpec/VariableDefinition cop. (@tejasbubane)
  • Expand Capybara/VisibilityMatcher to support more than just have_selector. (@twalpole)
  • Add new SpecSuffixOnly option to RSpec/FilePath cop. (@zdennis)
  • Allow RSpec/RepeatedExampleGroupBody to differ only by described_class. (@robotdana)
  • Fix RSpec/FilePath detection across sibling directories. (@rolfschmidt)
  • Improve the performance of RSpec/SubjectStub by an order of magnitude. (@andrykonchin)

1.39.0

  • Fix RSpec/FilePath detection when absolute path includes test subject. (@eitoball)
  • Add new Capybara/VisibilityMatcher cop. (@aried3r)
  • Ignore String constants by RSpec/Describe. (@AlexWayfer)
  • Drop support for Ruby 2.3. (@bquorning)
  • Fix multiple cops to detect let with proc argument. (@tejasbubane)
  • Add autocorrect support for RSpec/ScatteredLet. (@Darhazer)
  • Add new RSpec/EmptyHook cop. (@tejasbubane)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ rubocop (0.84.0 → 0.86.0) · Repo · Changelog

Release Notes

0.86.0

New features

  • #8147: Add new Style/RedundantFetchBlock cop. (@fatkodima)
  • #8111: Add auto-correct for Style/StructInheritance. (@tejasbubane)
  • #8113: Let expect_offense templates add variable-length whitespace with _{foo}. (@eugeneius)
  • #8148: Support auto-correction for Style/MultilineTernaryOperator. (@koic)
  • #8151: Support auto-correction for Style/NestedTernaryOperator. (@koic)
  • #8142: Add Lint/ConstantResolution cop. (@robotdana)
  • #8170: Support auto-correction for Lint/RegexpAsCondition. (@koic)
  • #8169: Support auto-correction for Lint/RaiseException. (@koic)

Bug fixes

  • #8132: Fix the problem with Naming/MethodName: EnforcedStyle: camelCase and _ or i variables. (@avrusanov)
  • #8115: Fix false negative for Lint::FormatParameterMismatch when argument contains formatting. (@andrykonchin)
  • #8131: Fix false positive for Style/RedundantRegexpEscape with escaped delimiters. (@owst)
  • #8124: Fix a false positive for Lint/FormatParameterMismatch when using named parameters with escaped %. (@koic)
  • #7979: Fix "uninitialized constant DidYouMean::SpellChecker" exception. (@bquorning)
  • #8098: Fix a false positive for Style/RedundantRegexpCharacterClass when using interpolations. (@owst)
  • #8150: Fix a false positive for Layout/EmptyLinesAroundAttributeAccessor when using attribute accessors in if ... else branches. (@koic)
  • #8179: Fix an infinite correction loop error for Layout/MultilineBlockLayout when missing newline before opening parenthesis ( for block body. (@koic)
  • #8185: Fix a false positive for Style/YodaCondition when interpolation is used on the left hand side. (@koic)

Changes

  • #8146: Use UTC in RuboCop todo file generation. (@mauro-oto)
  • #8149: Cop Metrics/CyclomaticComplexity now counts &., ||=, &&= and blocks known to iterate. Default bumped from 6 to 7. (@marcandre)
  • #8178: Mark unsafe for Lint/RaiseException. (@koic)

0.85.1

Bug fixes

  • #8083: Fix an error for Lint/MixedRegexpCaptureTypes cop when using a regular expression that cannot be processed by regexp_parser gem. (@koic)
  • #8081: Fix a false positive for Lint/SuppressedException when empty rescue block in do block. (@koic)
  • #8096: Fix a false positive for Lint/SuppressedException when empty rescue block in defs. (@koic)
  • #8108: Fix infinite loop in Layout/HeredocIndentation auto-correct. (@jonas054)
  • #8042: Fix raising error in Lint::FormatParameterMismatch when it handles invalid format strings and add new offense. (@andrykonchin)

0.85.0

New features

  • #6289: Add new CheckDefinitionPathHierarchy option for Naming/FileName. (@jschneid)
  • #8055: Add new Style/RedundantRegexpCharacterClass cop. (@owst)
  • #8069: New option for expect_offense to help format offense templates. (@marcandre)
  • #7908: Add new Style/RedundantRegexpEscape cop. (@owst)
  • #7978: Add new option OnlyFor to the Bundler/GemComment cop. (@ric2b)
  • #8063: Add new AllowedNames option for Naming/ClassAndModuleCamelCase. (@tejasbubane)
  • #8050: New option --display-only-failed that can be used with --format junit. Speeds up test report processing for large codebases and helps address the sorts of concerns raised at mikian/rubocop-junit-formatter #18. (@burnettk)
  • #7746: Add new Lint/MixedRegexpCaptureTypes cop. (@pocke)

Bug fixes

  • #8008: Fix an error for Lint/SuppressedException when empty rescue block in def. (@koic)
  • #8012: Fix an incorrect autocorrect for Lint/DeprecatedOpenSSLConstant when deprecated OpenSSL constant is used in a block. (@koic)
  • #8017: Fix a false positive for Lint/SuppressedException when empty rescue with comment in def. (@koic)
  • #7990: Fix resolving inherit_gem in remote configs. (@CvX)
  • #8035: Fix a false positive for Lint/DeprecatedOpenSSLConstant when using double quoted string argument. (@koic)
  • #7971: Fix an issue where --disable-uncorrectable would not update uncorrected code with rubocop:todo. (@rrosenblum)
  • #8035: Fix a false positive for Lint/DeprecatedOpenSSLConstant when argument is a variable, method, or consntant. (@koic)

Changes

  • #8056: (Breaking) Remove support for unindent/active_support/powerpack from Layout/HeredocIndentation, so it only recommends using squiggy heredoc. (@bquorning)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ ast (indirect, 2.4.0 → 2.4.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 7 commits:

↗️ parallel (indirect, 1.19.1 → 1.19.2) · Repo

Commits

See the full diff on Github. The new version differs by 6 commits:

↗️ parser (indirect, 2.7.1.2 → 2.7.1.4) · Repo · Changelog

Release Notes

2.7.1.4 (from changelog)

Features implemented:

  • ruby28.y: add find pattern. (#714) (Ilya Bylich)
  • lexer.rl: reject ->... and ->(...) with the same error. (#713) (Ilya Bylich)
  • ruby28.y: accept leading args before forward arg. (#712) (Ilya Bylich)
  • Added emit_forward_arg compatibility flag. (#710) (Ilya Bylich)
  • ruby28.y: include entire lambda expr in lambda rule. (#708) (Ilya Bylich)
  • ruby28.y: extracted excessed_comma rule. (#706) (Ilya Bylich)
  • Source::TreeRewriter: Improved merging and representations (#703) (Marc-André Lafortune)

Bugs fixed:

  • ruby*.y: fixed context inside lambda args and module. (#709) (Ilya Bylich)

2.7.1.3 (from changelog)

API modifications:

  • fixed all warnings. tests are running in verbose mode now. (#685) (Ilya Bylich)

Features implemented:

  • ruby-[parse, rewrite]: add legacy switches (#699) (Marc-André Lafortune)
  • Added Parser::Source::Range#to_range. (#697) (Ilya Bylich)
  • ruby28.y: support rescue modifier in endless method definition. (#696) (Ilya Bylich)
  • ruby28.y: unify kwrest and no-kwrest rules. (#694) (Ilya Bylich)
  • ruby28.y: add right hand assignment (#682) (Vladimir Dementyev)

Bugs fixed:

  • fix Comment.associate for postfix conditions/loops (#688) (Marc-André Lafortune)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 24 commits:

↗️ rubocop-ast (indirect, 0.0.3 → 0.1.0) · Repo · Changelog

Release Notes

0.1.0 (from changelog)

New features

  • #36: Add post_condition_loop? and loop_keyword? for Node. (@fatkodima)
  • #38: Add helpers allowing to check whether the method is a nonmutating operator method or a nonmutating method of several core classes. (@fatkodima)
  • #37: Add enumerable_method? for MethodIdentifierPredicates. (@fatkodima)
  • #4: Add interpolation? for RegexpNode. (@tejasbubane)
  • #20: Add option predicates for RegexpNode. (@owst)
  • #11: Add argument_type? method to make it easy to recognize argument nodes. (@tejasbubane)
  • #31: NodePattern now uses param === node to match params, which allows Regexp, Proc, Set in addition to Nodes and literals. (@marcandre)
  • #41: Add delimiters and related predicates for RegexpNode. (@owst)
  • #46: Basic support for non-legacy AST output from parser. Note that there is no support (yet) in main RuboCop gem. Expect emit_forward_arg to be set to true in v1.0 (@marcandre)
  • #48: Support Parser::Ruby28 for Ruby 2.8 (3.0) parser (experimental). ([@koic][])
  • #35: NodePattern now accepts %named_param and %CONST. The macros def_node_pattern and def_node_search accept default named parameters. (@marcandre)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 49 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu
Copy link
Contributor Author

depfu bot commented Jul 11, 2020

Closed in favor of #640.

@depfu depfu bot closed this Jul 11, 2020
@depfu depfu bot deleted the depfu/update/rubocop-rspec-1.41.0 branch July 11, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants