Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rspec: 1.38.1 → 1.43.1 (minor) #641

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Aug 18, 2020

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (1.38.1 → 1.43.1) · Repo · Changelog

Release Notes

1.43.1

Fix RSpec/FilePath when checking a file defining e.g. an empty class. (@bquorning)

1.43.0

  • Add a new base cop class ::RuboCop::Cop::RSpec::Base. The old base class ::RuboCop::Cop::RSpec::Cop is deprecated, and will be removed in the next major release. (@bquorning)
  • Add support for subject detection after includes and example groups in RSpec/LeadingSubject. (@pirj)
  • Ignore trailing punctuation in context description prefix. (@elliterate)
  • Relax RSpec/VariableDefinition cop so interpolated and multiline strings are accepted even when configured to enforce the symbol style. (@bquorning)
  • Fix RSpec/EmptyExampleGroup to flag example groups with examples in invalid scopes. (@mlarraz)
  • Fix RSpec/EmptyExampleGroup to ignore examples groups with examples defined inside iterators. (@pirj)
  • Improve RSpec/NestedGroups, RSpec/FilePath, RSpec/DescribeMethod, RSpec/MultipleDescribes, RSpec/DescribeClass's top-level example group detection. (@pirj)
  • Add detection of let! with a block-pass or a string literal to RSpec/LetSetup. (@pirj)
  • Add IgnoredPatterns configuration option to RSpec/VariableName. (@jtannas)
  • Add RSpec/MultipleMemoizedHelpers cop. (@mockdeep)

1.42.0

  • Update RuboCop dependency to 0.87.0 because of changes to internal APIs. (@bquorning, @Darhazer)

1.41.0

  • Extend the list of Rails spec types for RSpec/DescribeClass. (@pirj)
  • Fix FactoryBot/AttributeDefinedStatically to allow #traits_for_enum without a block. (@harrylewis)
  • Improve the performance of FactoryBot/AttributeDefinedStatically, RSpec/InstanceVariable, RSpec/LetSetup, RSpec/NestedGroups and RSpec/ReturnFromStub. (@andrykonchin)

1.40.0

  • Add new RSpec/VariableName cop. (@tejasbubane)
  • Add new RSpec/VariableDefinition cop. (@tejasbubane)
  • Expand Capybara/VisibilityMatcher to support more than just have_selector. (@twalpole)
  • Add new SpecSuffixOnly option to RSpec/FilePath cop. (@zdennis)
  • Allow RSpec/RepeatedExampleGroupBody to differ only by described_class. (@robotdana)
  • Fix RSpec/FilePath detection across sibling directories. (@rolfschmidt)
  • Improve the performance of RSpec/SubjectStub by an order of magnitude. (@andrykonchin)

1.39.0

  • Fix RSpec/FilePath detection when absolute path includes test subject. (@eitoball)
  • Add new Capybara/VisibilityMatcher cop. (@aried3r)
  • Ignore String constants by RSpec/Describe. (@AlexWayfer)
  • Drop support for Ruby 2.3. (@bquorning)
  • Fix multiple cops to detect let with proc argument. (@tejasbubane)
  • Add autocorrect support for RSpec/ScatteredLet. (@Darhazer)
  • Add new RSpec/EmptyHook cop. (@tejasbubane)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ rubocop (0.84.0 → 0.89.1) · Repo · Changelog

Release Notes

0.89.1

Bug fixes

  • #8463: Fix false positives for Lint/OutOfRangeRegexpRef when a regexp is defined and matched in separate steps. (@eugeneius)
  • #8464: Handle regexps matched with when, grep, gsub, gsub!, sub, sub!, [], slice, slice!, scan, index, rindex, partition, rpartition, start_with?, and end_with? in Lint/OutOfRangeRegexpRef. (@eugeneius)
  • #8466: Fix a false positive for Lint/UriRegexp when using regexp method without receiver. (@koic)
  • #8478: Relax Lint/BinaryOperatorWithIdenticalOperands for mathematical operations. (@marcandre)
  • #8480: Tweak callback list of Lint/MissingSuper. (@marcandre)
  • #8481: Fix autocorrect for elements with newlines in Style/SymbolArray and Style/WordArray. (@biinari)
  • #8475: Fix a false positive for Style/HashAsLastArrayItem when there are duplicate hashes in the array. (@wcmonty)
  • #8497: Fix Style/IfUnlessModifier to add parentheses when converting if-end condition inside a parenthesized method argument list. (@dsavochkin)

Changes

  • #8487: Detect < and > as comparison operators in Style/ConditionalAssignment cop. (@biinari)

0.89.0

New features

Bug fixes

  • #8346: Allow parentheses in single-line inheritance with Style/MethodCallWithArgsParentheses EnforcedStyle: omit_parentheses to fix invalid Ruby auto-correction. (@gsamokovarov)
  • #8324: Fix crash for Layout/SpaceAroundMethodCallOperator when using Proc#call shorthand syntax. (@fatkodima)
  • #8332: Fix auto-correct in Style/ConditionalAssignment to preserve constant namespace. (@biinari)
  • #8344: Fix crash for Style/CaseLikeIf when checking against equal? and match? without a receiver. (@fatkodima)
  • #8323: Fix a false positive for Style/HashAsLastArrayItem when hash is not a last array item. (@fatkodima)
  • #8299: Fix an incorrect auto-correct for Style/RedundantCondition when using raise, rescue, or and without argument parentheses in else. (@koic)
  • #8335: Fix incorrect character class detection for nested or POSIX bracket character classes in Style/RedundantRegexpEscape. (@owst)
  • #8347: Fix an incorrect auto-correct for EnforcedStyle: hash_rockets of Style/HashSyntax with Layout/HashAlignment. (@koic)
  • #8375: Fix an infinite loop error for Style/EmptyMethod. (@koic)
  • #8385: Remove auto-correction for Lint/EnsureReturn. (@marcandre)
  • #8391: Mark Style/ArrayCoercion as not safe. (@marcandre)
  • #8406: Improve Style/AccessorGrouping's auto-correction to remove redundant blank lines. (@koic)
  • #8330: Fix a false positive for Style/MissingRespondToMissing when defined method with inline access modifier. (@koic)
  • #8422: Fix an error for Lint/SelfAssignment when using or-assignment for constant. (@koic)
  • #8423: Fix an error for Style/SingleArgumentDig when without a receiver. (@koic)
  • #8424: Fix an error for Lint/IneffectiveAccessModifier when there is begin...end before a method definition. (@koic)
  • #8006: Fix line length calculation for Style/IfUnlessModifier to correctly take into account code before the if condition when considering conversation to a single-line form. (@dsavochkin)
  • #8283: Fix line length calculation for Style/IfUnlessModifier to correctly take into account a comment on the first line when considering conversation to a single-line form. (@dsavochkin)
  • #7957: Fix line length calculation for Style/IfUnlessModifier to correctly take into account code on the last line after the end keyword when considering conversion to a single-line form. (@dsavochkin)
  • #8226: Fix Style/IfUnlessModifier to add parentheses when converting if-end condition inside an array or a hash to a single-line form. (@dsavochkin)
  • #8443: Fix an incorrect auto-correct for Style/StructInheritance when there is a comment before class declaration. (@koic)
  • #8444: Fix an error for Layout/FirstMethodArgumentLineBreak when using kwargs in super. (@koic)

Changes

  • #8376: Style/MethodMissingSuper cop is removed in favor of new Lint/MissingSuper cop. (@fatkodima)
  • #8433: Lint/UselessComparison cop is removed in favor of new Lint/BinaryOperatorWithIdenticalOperands cop. (@fatkodima)
  • #8350: Set default max line length to 120 for Style/MultilineMethodSignature. (@koic)
  • #8338: potentially breaking. Config#for_department now returns only the config specified for that department; the 'Enabled' attribute is no longer calculated. (@marcandre)
  • #8037: (Breaking) Cop Metrics/AbcSize now counts ||=, &&=, multiple assignments, for, yield, iterating blocks. &. now count as conditions too (unless repeated on the same variable). Default bumped from 15 to 17. Consider using rubocop -a --disable-uncorrectable to ease transition. (@marcandre)
  • #8276: Cop Metrics/CyclomaticComplexity not longer counts &. when repeated on the same variable. (@marcandre)
  • #8204: (Breaking) Cop Metrics/PerceivedComplexity now counts else in case statements, &., ||=, &&= and blocks known to iterate. Default bumped from 7 to 8. Consider using rubocop -a --disable-uncorrectable to ease transition. (@marcandre)
  • #8416: Cop Lint/InterpolationCheck marked as unsafe. (@marcandre)
  • #8442: Remove RuboCop::Cop::ParserDiagnostic mixin module. (@koic)

0.88.0

New features

Bug fixes

  • #8232: Fix a false positive for Layout/EmptyLinesAroundAccessModifier when end immediately after access modifier. (@koic)
  • #7777: Fix crash for Layout/MultilineArrayBraceLayout when comment is present after last element. (@shekhar-patil)
  • #7776: Fix crash for Layout/MultilineMethodCallBraceLayout when comment is present before closing braces. (@shekhar-patil)
  • #8282: Fix Style/IfUnlessModifier bad precedence detection. (@tejasbubane)
  • #8289: Fix Style/AccessorGrouping to not register offense for accessor with comment. (@tejasbubane)
  • #8310: Handle major version requirements in Gemspec/RequiredRubyVersion. (@eugeneius)
  • #8315: Fix crash for Style/PercentLiteralDelimiters when the source contains invalid characters. (@eugeneius)
  • #8239: Don't load .rubocop.yml files at all outside of the current project, unless they are personal configuration files and the project has no configuration. (@deivid-rodriguez)

Changes

  • #8021: Rewrite Layout/SpaceAroundMethodCallOperator cop to make it faster. (@fatkodima)
  • #8294: Add of to AllowedNames of MethodParameterName cop. (@AlexWayfer)

0.87.1

Bug fixes

  • #8252: Fix a command line option name from --safe-autocorrect to --safe-auto-correct, which is compatible with RuboCop 0.86 and lower. (@koic)
  • #8259: Fix false positives for Style/BisectedAttrAccessor when accessors have different access modifiers. (@fatkodima)
  • #8253: Fix false positives for Style/AccessorGrouping when accessors have different access modifiers. (@fatkodima)
  • #8257: Fix an error for Style/BisectedAttrAccessor when using attr_reader and attr_writer with splat arguments. (@fatkodima)
  • #8239: Don't load .rubocop.yml from personal folders to check for exclusions if given a custom configuration file. (@deivid-rodriguez)
  • #8256: Fix an error for --auto-gen-config when running a cop who do not support auto-correction. (@koic)
  • #8262: Fix Lint/DeprecatedOpenSSLConstant auto-correction of OpenSSL::Cipher to use lower case, as some Linux-based systems do not accept upper cased cipher names. (@bdewater)

0.87.0

New features

  • #7868: Cop::Base is the new recommended base class for cops. (@marcandre)
  • #3983: Add new Style/AccessorGrouping cop. (@fatkodima)
  • #8244: Add new Style/BisectedAttrAccessor cop. (@fatkodima)
  • #7458: Add new AsciiConstants option for Naming/AsciiIdentifiers. (@fatkodima)
  • #7373: Add new Style/RedundantAssignment cop. (@fatkodima)
  • #8213: Permit to specify TargetRubyVersion 2.8 (experimental). (@koic)
  • #8159: Add new CountAsOne option for code length related Metric cops. (@fatkodima)
  • #8164: Support auto-correction for Lint/InterpolationCheck. (@koic)
  • #8223: Support auto-correction for Style/IfUnlessModifierOfIfUnless. (@koic)
  • #8172: Support auto-correction for Lint/SafeNavigationWithEmpty. (@koic)

Bug fixes

  • #8039: Fix false positives for Lint/ParenthesesAsGroupedExpression in when using operators or chain functions. (@CamilleDrapier)
  • #8196: Fix a false positive for Style/RedundantFetchBlock when using with Rails.cache. (@fatkodima)
  • #8195: Fix an error for Style/RedundantFetchBlock when using #fetch with empty block. (@koic)
  • #8193: Fix a false positive for Style/RedundantRegexpCharacterClass when using [\b]. (@owst)
  • #8205: Fix a false positive for Style/RedundantRegexpCharacterClass when using a leading escaped ]. (@owst)
  • #8208: Fix Style/RedundantParentheses with hash literal as first argument to yield. (@karlwithak)
  • #8176: Don't load .rubocop.yml from personal folders to check for exclusions if there's a project configuration. (@deivid-rodriguez)

Changes

  • #7868: (Breaking) Extensive refactoring of internal classes Team, Commissioner, Corrector. Cop::Cop#corrections not completely compatible. See Upgrade Notes. (@marcandre)
  • #8156: (Breaking) rubocop -a / --autocorrect no longer run unsafe corrections; rubocop -A / --autocorrect-all run both safe and unsafe corrections. Options --safe-autocorrect is deprecated. (@marcandre)
  • #8207: (Breaking) Order for gems names now disregards underscores and dashes unless ConsiderPunctuation setting is set to true. (@marcandre)
  • #8211: Style/ClassVars cop now detects class_variable_set. (@biinari)
  • #8245: Detect top-level constants like ::Const in various cops. (@biinari)

0.86.0

New features

  • #8147: Add new Style/RedundantFetchBlock cop. (@fatkodima)
  • #8111: Add auto-correct for Style/StructInheritance. (@tejasbubane)
  • #8113: Let expect_offense templates add variable-length whitespace with _{foo}. (@eugeneius)
  • #8148: Support auto-correction for Style/MultilineTernaryOperator. (@koic)
  • #8151: Support auto-correction for Style/NestedTernaryOperator. (@koic)
  • #8142: Add Lint/ConstantResolution cop. (@robotdana)
  • #8170: Support auto-correction for Lint/RegexpAsCondition. (@koic)
  • #8169: Support auto-correction for Lint/RaiseException. (@koic)

Bug fixes

  • #8132: Fix the problem with Naming/MethodName: EnforcedStyle: camelCase and _ or i variables. (@avrusanov)
  • #8115: Fix false negative for Lint::FormatParameterMismatch when argument contains formatting. (@andrykonchin)
  • #8131: Fix false positive for Style/RedundantRegexpEscape with escaped delimiters. (@owst)
  • #8124: Fix a false positive for Lint/FormatParameterMismatch when using named parameters with escaped %. (@koic)
  • #7979: Fix "uninitialized constant DidYouMean::SpellChecker" exception. (@bquorning)
  • #8098: Fix a false positive for Style/RedundantRegexpCharacterClass when using interpolations. (@owst)
  • #8150: Fix a false positive for Layout/EmptyLinesAroundAttributeAccessor when using attribute accessors in if ... else branches. (@koic)
  • #8179: Fix an infinite correction loop error for Layout/MultilineBlockLayout when missing newline before opening parenthesis ( for block body. (@koic)
  • #8185: Fix a false positive for Style/YodaCondition when interpolation is used on the left hand side. (@koic)

Changes

  • #8146: Use UTC in RuboCop todo file generation. (@mauro-oto)
  • #8149: Cop Metrics/CyclomaticComplexity now counts &., ||=, &&= and blocks known to iterate. Default bumped from 6 to 7. (@marcandre)
  • #8178: Mark unsafe for Lint/RaiseException. (@koic)

0.85.1

Bug fixes

  • #8083: Fix an error for Lint/MixedRegexpCaptureTypes cop when using a regular expression that cannot be processed by regexp_parser gem. (@koic)
  • #8081: Fix a false positive for Lint/SuppressedException when empty rescue block in do block. (@koic)
  • #8096: Fix a false positive for Lint/SuppressedException when empty rescue block in defs. (@koic)
  • #8108: Fix infinite loop in Layout/HeredocIndentation auto-correct. (@jonas054)
  • #8042: Fix raising error in Lint::FormatParameterMismatch when it handles invalid format strings and add new offense. (@andrykonchin)

0.85.0

New features

  • #6289: Add new CheckDefinitionPathHierarchy option for Naming/FileName. (@jschneid)
  • #8055: Add new Style/RedundantRegexpCharacterClass cop. (@owst)
  • #8069: New option for expect_offense to help format offense templates. (@marcandre)
  • #7908: Add new Style/RedundantRegexpEscape cop. (@owst)
  • #7978: Add new option OnlyFor to the Bundler/GemComment cop. (@ric2b)
  • #8063: Add new AllowedNames option for Naming/ClassAndModuleCamelCase. (@tejasbubane)
  • #8050: New option --display-only-failed that can be used with --format junit. Speeds up test report processing for large codebases and helps address the sorts of concerns raised at mikian/rubocop-junit-formatter #18. (@burnettk)
  • #7746: Add new Lint/MixedRegexpCaptureTypes cop. (@pocke)

Bug fixes

  • #8008: Fix an error for Lint/SuppressedException when empty rescue block in def. (@koic)
  • #8012: Fix an incorrect autocorrect for Lint/DeprecatedOpenSSLConstant when deprecated OpenSSL constant is used in a block. (@koic)
  • #8017: Fix a false positive for Lint/SuppressedException when empty rescue with comment in def. (@koic)
  • #7990: Fix resolving inherit_gem in remote configs. (@CvX)
  • #8035: Fix a false positive for Lint/DeprecatedOpenSSLConstant when using double quoted string argument. (@koic)
  • #7971: Fix an issue where --disable-uncorrectable would not update uncorrected code with rubocop:todo. (@rrosenblum)
  • #8035: Fix a false positive for Lint/DeprecatedOpenSSLConstant when argument is a variable, method, or consntant. (@koic)

Changes

  • #8056: (Breaking) Remove support for unindent/active_support/powerpack from Layout/HeredocIndentation, so it only recommends using squiggy heredoc. (@bquorning)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ ast (indirect, 2.4.0 → 2.4.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parallel (indirect, 1.19.1 → 1.19.2) · Repo

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parser (indirect, 2.7.1.2 → 2.7.1.4) · Repo · Changelog

Release Notes

2.7.1.4 (from changelog)

Features implemented:

  • ruby28.y: add find pattern. (#714) (Ilya Bylich)
  • lexer.rl: reject ->... and ->(...) with the same error. (#713) (Ilya Bylich)
  • ruby28.y: accept leading args before forward arg. (#712) (Ilya Bylich)
  • Added emit_forward_arg compatibility flag. (#710) (Ilya Bylich)
  • ruby28.y: include entire lambda expr in lambda rule. (#708) (Ilya Bylich)
  • ruby28.y: extracted excessed_comma rule. (#706) (Ilya Bylich)
  • Source::TreeRewriter: Improved merging and representations (#703) (Marc-André Lafortune)

Bugs fixed:

  • ruby*.y: fixed context inside lambda args and module. (#709) (Ilya Bylich)

2.7.1.3 (from changelog)

API modifications:

  • fixed all warnings. tests are running in verbose mode now. (#685) (Ilya Bylich)

Features implemented:

  • ruby-[parse, rewrite]: add legacy switches (#699) (Marc-André Lafortune)
  • Added Parser::Source::Range#to_range. (#697) (Ilya Bylich)
  • ruby28.y: support rescue modifier in endless method definition. (#696) (Ilya Bylich)
  • ruby28.y: unify kwrest and no-kwrest rules. (#694) (Ilya Bylich)
  • ruby28.y: add right hand assignment (#682) (Vladimir Dementyev)

Bugs fixed:

  • fix Comment.associate for postfix conditions/loops (#688) (Marc-André Lafortune)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rubocop-ast (indirect, 0.0.3 → 0.3.0) · Repo · Changelog

Release Notes

0.3.0 (from changelog)

New features

Bug fixes

  • #70: Fix arguments processing for BreakNode (@marcandre)
  • #70: (Potentially breaking) BreakNode and ReturnNode no longer include MethodDispatchNode. These methods were severely broken (@marcandre)

Changes

  • #44: (Breaking) Use parser flag self.emit_forward_arg = true by default. (@marcandre)
  • #86: PairNode#delimiter and inverse_delimiter now accept their argument as a named argument. (@marcandre)
  • #87: (Potentially breaking) Have IfNode#branches return a nil value if source has else; end (@marcandre)

0.2.0 (from changelog)

New features

  • #50: Support find pattern matching for Ruby 2.8 (3.0) parser. (@koic)
  • #55: Add ProcessedSource#line_with_comment?. (@marcandre)
  • #63: NodePattern now supports patterns as arguments to predicate and functions. (@marcandre)
  • #64: Add Node#global_const?. (@marcandre)
  • #28: Add struct_constructor?, class_definition? and module_definition? matchers. (@tejasbubane)

Bug fixes

  • #55: Fix ProcessedSource#commented? for multi-line ranges. Renamed contains_comment? (@marcandre)
  • #69: (Potentially breaking) RetryNode has many errors. It is now a Node. (@marcandre)

0.1.0 (from changelog)

New features

  • #36: Add post_condition_loop? and loop_keyword? for Node. (@fatkodima)
  • #38: Add helpers allowing to check whether the method is a nonmutating operator method or a nonmutating method of several core classes. (@fatkodima)
  • #37: Add enumerable_method? for MethodIdentifierPredicates. (@fatkodima)
  • #4: Add interpolation? for RegexpNode. (@tejasbubane)
  • #20: Add option predicates for RegexpNode. (@owst)
  • #11: Add argument_type? method to make it easy to recognize argument nodes. (@tejasbubane)
  • #31: NodePattern now uses param === node to match params, which allows Regexp, Proc, Set in addition to Nodes and literals. (@marcandre)
  • #41: Add delimiters and related predicates for RegexpNode. (@owst)
  • #46: Basic support for non-legacy AST output from parser. Note that there is no support (yet) in main RuboCop gem. Expect emit_forward_arg to be set to true in v1.0 (@marcandre)
  • #48: Support Parser::Ruby28 for Ruby 2.8 (3.0) parser (experimental). ([@koic][])
  • #35: NodePattern now accepts %named_param and %CONST. The macros def_node_pattern and def_node_search accept default named parameters. (@marcandre)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu
Copy link
Contributor Author

depfu bot commented Aug 26, 2020

Closed in favor of #642.

@depfu depfu bot closed this Aug 26, 2020
@depfu depfu bot deleted the depfu/update/rubocop-rspec-1.43.1 branch August 26, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants