Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review] Request from 'aduffeck' @ 'SUSE/machinery/review_160209_fix_files_reported_multiple_times' #1965

Merged
merged 2 commits into from
Feb 9, 2016

Conversation

aduffeck
Copy link
Contributor

@aduffeck aduffeck commented Feb 9, 2016

Please review the following changes:

  • 119e627 Get rid of superfluous allow_any_instance_of usage
  • 9c86fe1 Handle cases where "rpm -V" returns multiple lines for the same file

In some cases a file belongs to multiple packages (resulting in a
"replaced" case). The file can then be reported multiple times by rpm
but should only be listed once by machinery.
missing /lib/modules/3.16.7-29-desktop/updates/vboxpci.ko (replaced)
missing /lib/modules/3.16.7-29-desktop/updates/vboxpci.ko
EOF
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align ) with (.

@mauromorales
Copy link
Contributor

lgtm

aduffeck added a commit that referenced this pull request Feb 9, 2016
…ultiple_times

[Review] Request from 'aduffeck' @ 'SUSE/machinery/review_160209_fix_files_reported_multiple_times'
@aduffeck aduffeck merged commit 452390d into master Feb 9, 2016
@aduffeck aduffeck deleted the review_160209_fix_files_reported_multiple_times branch February 9, 2016 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants