Move ZypperAuth.verify_instance to InstanceVerification engine #1149
Conversation
| ) | ||
| if File.exist?(cache_path) | ||
| # only update registry cache key | ||
| InstanceVerification.update_cache(request.remote_ip, system.login, nil, is_byos: system.proxy_byos, registry: true) |
There was a problem hiding this comment.
The is_byos key was removed with ccb4e6e ???
There was a problem hiding this comment.
The PR was created without the removal of BYOS changes in place
I have merged master branch into this branch so the removal of BYOS param is in place
| false | ||
| end | ||
|
|
||
| def self.build_cache_key(remote_ip, login, base_product_id: nil) |
There was a problem hiding this comment.
This seems more complicated than it needs to be. Is there any reason something simpler couldn't be used, since there's no check on the assigned values anyway?
def self.build_cache_key(*args)
args.compact.join('-')
end
|
Given that this is not a functionality change and more of a code cleanliness item let's make sure this does not get merged until after 2.17 is cut. We agreed 2.17 testing will start tomorrow and we do not want to interfere with the agreed upon timeline by merging more changes that force testing to start over. |
|
I will come back for review after 2.17 is done. |
Description
Move the instance verification check to the InstanceVerification engine
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
rubocop.MANUAL.mdfile with any changes to the user experience.package/obs/rmt-server.changes.Other Notes
Please use this space to provide notes or thoughts to the team, such as tips on how to review/demo your changes.