Refactor repository and registry cache #1150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjschwei
requested changes
May 13, 2024
| ) | ||
| # write repository cache | ||
| repository_cache_path = InstanceVerification.repository_cache_path(remote_ip, system_login, product_id) | ||
| InstanceVerification.write_cache_file(repository_cache_path) unless registry |
There was a problem hiding this comment.
We are already in an unless registry context, why do we need to test that again?
Also via the activations endpoint from the client side we do not send the product, because it is already known. Thus the question is whether we need the registry argument at all. If we have no product_id then we are on the registry path through the code, are we not?
There was a problem hiding this comment.
Good question, I was not 100% sure we could use the product identifier to differentiate between repositories/registry calls. I think we can
I will update this PR once #1149 is merged, so the changes can be applied to this one
engines/instance_verification/lib/instance_verification/engine.rb
Outdated
Show resolved
Hide resolved
- Remove registry cache in the same engine that it is created - Get repository and registry cache paths in one place to avoid duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
rubocop.MANUAL.mdfile with any changes to the user experience.package/obs/rmt-server.changes.Other Notes
Please use this space to provide notes or thoughts to the team, such as tips on how to review/demo your changes.