detect cloud aws workaround #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested changes
Mar 18, 2022
salt/states/crmshmod.py
Outdated
| @@ -596,6 +596,16 @@ def cloud_grains_present( | |||
| __salt__['grains.set']('cloud_provider', cloud_provider) | |||
| changes['cloud_provider'] = cloud_provider | |||
|
|
|||
| # workaround for https://github.com/SUSE/ha-sap-terraform-deployments/issues/832 | |||
There was a problem hiding this comment.
I would say this piece of code should go in the crm.detect_cloud module, and not here.
In fact, I don't know why we have the gcp part there as well.
This means that the detect_cloud module function is kind of broken otherwise
There was a problem hiding this comment.
The gcp part does not change the cloud_provider but additional grains gcp_instance_id/name.
I guess this is fine...I guess there is just no better place to set this at the moment.
There was a problem hiding this comment.
@arbulu89 Force pushed an update which moves this to the module.
yeoldegrove
force-pushed
the
detect_cloud_aws_workaround
branch
from
74ef4be
to
5699ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.