Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs and metrics semantics #23

Merged
merged 4 commits into from
Mar 20, 2020
Merged

Fix docs and metrics semantics #23

merged 4 commits into from
Mar 20, 2020

Conversation

stefanotorresi
Copy link
Collaborator

This PR fixes #11 and also update some incorrect metric semantics.

@stefanotorresi stefanotorresi added the wip work in progress, don't merge label Mar 20, 2020
@stefanotorresi
Copy link
Collaborator Author

marking as wip because depends on #21

@stefanotorresi stefanotorresi removed the wip work in progress, don't merge label Mar 20, 2020
@stefanotorresi
Copy link
Collaborator Author

@MalloZup rebased and ready for review

MalloZup
MalloZup approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@MalloZup MalloZup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@stefanotorresi stefanotorresi merged commit 1d95911 into SUSE:master Mar 20, 2020
@stefanotorresi stefanotorresi deleted the fix/metrics-semantics-and-docs branch March 20, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MalloZup MalloZup MalloZup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better document Enqueue Server metrics
2 participants
@stefanotorresi @MalloZup