Feature: alert metrics #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalloZup
reviewed
Mar 19, 2020
MalloZup
reviewed
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
alertcollector that implements the following metrics:sap_alert_ha_checksap_alert_ha_failover_activeIt also enriches the boilerplate of the
collectorpackage by adding a newRecordConcurrentlyfunction that helps dealing with multiple concurrent metric recording functions within the same colleciton cycle, which was needed to avoid hitting SAPControl sequentially and slowing down too much a single scrape.Some refactoring was also applied in the process of adding new webservice structures.