fix make obs-workdir target #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…references other than git tags
MalloZup
reviewed
Mar 23, 2020
MalloZup
reviewed
Mar 23, 2020
MalloZup
reviewed
Mar 23, 2020
MalloZup
suggested changes
Mar 23, 2020
|
@stefanotorresi thx. I think the printf format can be converted with
|
|
@MalloZup I used f-strings throughout the whole script! I don't see any compelling technical reason to change that now, to be honest. In fact, since the f-strings were introduced in Python, the best practice is to use those instead of |
MalloZup
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
ok. thx @stefanotorresi . Sarcastic mode oN: I guess python is not made for entreprise software.
I think I never discovered in my life a language that during is lifetyime has changed so many time useless syntax for printing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes on how the
make obs-workdirtarget works.It now uses the
HEADreference as a defaultVERSIONenvironment variable, and it now allows to also change theREPOSITORYvariable to make the OBStar_scmsource service fetch the sources from a different repository than the main upstream.Making OBS commits for Git feature branches on OBS branch packages is now documented in the development notes.
fixes #17