fix concurrent recording by using a waitgroup #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
I should have done this since the beginning: to simplify,
RecordConcurrently
only sent the first error that occurred among all the concurrent metric recording functions, returning as early as that error occurred.This could cause some of the goroutines to leak outside the life-cycle of
Collect
, causing a panic when trying to send on a closed metrics channel.To be fair I didn't know that, once
Collect
is done, the metric channel would be closed.The
RecordConcurrently
implementation now uses aWaitgroup
to wait for all the recording functions, avoiding any of them to leak, and returns all the errors in an array, instead of just the first.