Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge endpoint card changes, add kubernetes logo #135

Merged
merged 4 commits into from
Mar 19, 2019
Merged

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Mar 7, 2019

@richard-cox richard-cox self-assigned this Mar 7, 2019
# Conflicts:
#	src/frontend/packages/core/src/shared/components/list/list-types/endpoint/endpoint-card/endpoint-card.component.html
@codecov-io
Copy link

Codecov Report

Merging #135 into v2-master will decrease coverage by 44.97%.
The diff coverage is 26.16%.

@@              Coverage Diff              @@
##           v2-master    #135       +/-   ##
=============================================
- Coverage      71.18%   26.2%   -44.98%     
=============================================
  Files            754     742       -12     
  Lines          32703   19640    -13063     
  Branches        7513    3347     -4166     
=============================================
- Hits           23279    5147    -18132     
- Misses          9424   14493     +5069

@nwmac nwmac removed the blocked label Mar 19, 2019
@nwmac nwmac changed the base branch from v2-master to 1.0-release March 19, 2019 10:37
@nwmac nwmac changed the base branch from 1.0-release to v2-master March 19, 2019 10:37
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 7d0a729 into v2-master Mar 19, 2019
@nwmac nwmac deleted the endpoint-cards branch March 19, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants