Tech preview for helm feature #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2-master #190 +/- ##
============================================
- Coverage 53.27% 53.08% -0.2%
============================================
Files 914 916 +2
Lines 25105 25224 +119
Branches 4315 4321 +6
============================================
+ Hits 13375 13390 +15
- Misses 11730 11834 +104 |
richard-cox
requested changes
Aug 23, 2019
There was a problem hiding this comment.
Looks good, spotted the following issues though
kube dashboard requires sameorigin fix as per Complete Kube dashboard feature #151- helm chart summary add repo/install buttons are invisible, only install command (semi) copies text
helm endpoint card is greyed out as if it were disconnected, even when synchronisedhelm endpoint card 'synchronising' spinner continues after sync has finished. It looks like there's no http request related to helm, could be another status related issue
richard-cox
added
in review
needs attention
richard-cox
approved these changes
Aug 28, 2019
There was a problem hiding this comment.
LGTM, will merge once passed gates
One thing to note, with a helm endpoint already registered and helm disabled I got a backend panic in info.go line 97 s.Endpoints[cnsiType][cnsi.GUID] = endpoint. I don't think this is an issue we need to address now though due to the likelihood of an existing helm endpoint or toggling between enabled/disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.