Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for connecting CaaSP V4 endpoints #191

Merged
merged 4 commits into from
Aug 30, 2019
Merged

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Aug 23, 2019

No description provided.

@nwmac nwmac self-assigned this Aug 23, 2019
@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #191 into v2-master will increase coverage by 0.01%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##           v2-master     #191      +/-   ##
=============================================
+ Coverage      53.05%   53.07%   +0.01%     
=============================================
  Files            916      916              
  Lines          25249    25251       +2     
  Branches        4325     4327       +2     
=============================================
+ Hits           13397    13402       +5     
+ Misses         11852    11849       -3

@nwmac nwmac changed the base branch from v2-master to susecon August 27, 2019 12:44
@nwmac nwmac changed the base branch from susecon to v2-master August 27, 2019 12:44
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested with minikube & cf and both are still fine. Will test again with caasp v4

Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with CaaSP v4, will merge once passed gates

@richard-cox richard-cox merged commit 4b94b5c into v2-master Aug 30, 2019
@richard-cox richard-cox deleted the caasp4 branch August 30, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants