Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DB directory to be specified for SQLite #193

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Aug 28, 2019

No description provided.

@nwmac nwmac added the ready for review Ready for review label Aug 28, 2019
@nwmac nwmac self-assigned this Aug 28, 2019
@codecov-io
Copy link

Codecov Report

Merging #193 into v2-master will increase coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           v2-master     #193      +/-   ##
=============================================
+ Coverage      53.27%   53.29%   +0.01%     
=============================================
  Files            914      914              
  Lines          25105    25105              
  Branches        4315     4315              
=============================================
+ Hits           13375    13380       +5     
+ Misses         11730    11725       -5

Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once passed gates

@nwmac nwmac merged commit 0a2cd6c into v2-master Aug 28, 2019
@nwmac nwmac deleted the sqlite-dbdir branch August 28, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants