Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscaler Tweaks & Fixes #196

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Autoscaler Tweaks & Fixes #196

merged 2 commits into from
Sep 4, 2019

Conversation

richard-cox
Copy link
Member

Contains changes from cloudfoundry#3817
&
Handle errors better …

  • Remove another place where content from store is edited
  • Handle errors when there are no response (don't check for noPolicy)
  • Correctly wire in error handler for detach/delete policy
  • Clean & fix update policy handler

- Remove another place where content from store is edited
- Handle errors when there are no response (don't check for noPolicy)
- Correctly wire in error handler for detach/delete policy
- Clean & fix update policy handler
@richard-cox richard-cox added the ready for review Ready for review label Sep 3, 2019
@richard-cox richard-cox self-assigned this Sep 3, 2019
@codecov-io
Copy link

Codecov Report

Merging #196 into v2-master will increase coverage by 0.03%.
The diff coverage is 44.11%.

@@              Coverage Diff              @@
##           v2-master     #196      +/-   ##
=============================================
+ Coverage      53.12%   53.15%   +0.03%     
=============================================
  Files            917      918       +1     
  Lines          25268    25286      +18     
  Branches        4328     4335       +7     
=============================================
+ Hits           13424    13442      +18     
  Misses         11844    11844

Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 5620409 into v2-master Sep 4, 2019
@nwmac nwmac deleted the autoscaler-fixes branch September 4, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants