Fixes/Improvements following helm walkthrough #2 #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
richard-cox
commented
Jan 31, 2020
•
richard-cox
commented
- blocked on Fix stale pods #298
- fixes V3 walkthrough #2 issues #299
- Since cloudfoundry@7c94858 we take action.entity as paramount - In multi action lists for the secondary type this was incorrectly set to the primary type
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=========================================
- Coverage 59.06% 59% -0.06%
=========================================
Files 1027 1029 +2
Lines 31880 32059 +179
Branches 4359 4388 +29
=========================================
+ Hits 18829 18917 +88
- Misses 13051 13142 +91 |
nwmac
reviewed
Feb 4, 2020
| return; | ||
| } | ||
|
|
||
| obs.pipe(delay(999999999)).subscribe(() => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.